934594 - Add memcached support to buildapi

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

Buildapi currently uses redis as a caching backend.  It has a stub implementation of memcached, but no actual code.  We'll need to add memcached support in order to move off of redis.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Chris, per our meeting yesterday, I think it's reasonable for me to proceed with this - sound good?  For signing (bug 934623), the proper solution remains to be seen.

Comment 2

[Chris AtLee [:catlee]]

sure, sounds good.

One thing to watch out for is max value size. I think we ended up having to gzip some data so it would fit in a single redis key.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

The max for a Redis key is 512M, while the max for Memcached is 1MB.  The biggest key I see in redis right now is a bit over 3K.  So I think we're safe..

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug934594.patch

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 829515 [details] [diff] [review]
bug934594.patch

I'm not particularly sure what to do with the test script, but it did uncover bugs in the redis implementation.

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

As I mentioned yesterday, I'd like to land this regardless of whether we we use memcached, since it fixes redis bugs.  If you'd like, I can redraft with the memcached stuff removed.

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

I made the log.exception change you mentioned in irc.