Closed
Bug 934615
Opened 12 years ago
Closed 12 years ago
Buffer.isEncoding should fail for `undefined`
Categories
(Add-on SDK Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jsantell, Assigned: jsantell)
Details
Attachments
(1 file)
Change in `TextDecoder` causes Buffer.isEncoding(undefined) to pass, when it should fail. This fixes the change in TextDecoder.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #826947 -
Flags: review?(evold)
|
||
Updated•12 years ago
|
Attachment #826947 -
Flags: review?(evold) → review+
|
||
Comment 2•12 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/6301e57de31046751803fbdd74984a4cb165076e
Bug 934615 - Fix for change in TextDecoder for Buffer.isEncoding to properly fail when passed 'undefined'
https://github.com/mozilla/addon-sdk/commit/8cad63bcfe329794ecf3757c4fa25da5e2acd1a1
Merge pull request #1278 from jsantell/934615
Fix Bug 934615 - Fix for change in TextDecoder for Buffer.isEncoding to properly fail for 'undefined'; r=@erikvold
|
|
||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•