Closed
Bug 934676
Opened 12 years ago
Closed 11 years ago
Remove unused variable 'extracted' in ClientAuthDataRunnable::RunOnTargetThread
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: keeler, Assigned: retornam)
Details
(Whiteboard: [good first bug])
Attachments
(1 file, 2 obsolete files)
|
1.35 KB,
patch
|
Details | Diff | Splinter Review |
2095 char* extracted = nullptr;
...
2473 if (extracted) {
2474 PR_Free(extracted);
2475 }
|
Reporter | |
Comment 1•11 years ago
|
||
Jackson, are you still interested in working on this?
Flags: needinfo?(jacksonisaac2008)
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #8404983 -
Flags: review?(dkeeler)
|
|
Reporter | |
Comment 3•11 years ago
|
||
Comment on attachment 8404983 [details] [diff] [review]
bug-934676.patch
Review of attachment 8404983 [details] [diff] [review]:
-----------------------------------------------------------------
Perfect - r=me.
Attachment #8404983 -
Flags: review?(dkeeler) → review+
|
|
Reporter | |
Updated•11 years ago
|
Assignee: jacksonisaac2008 → mozbugs.retornam
Flags: needinfo?(jacksonisaac2008)
|
||
Comment 4•11 years ago
|
||
Hi David,
I am sorry for inactivity. It would be good if someone else can take this up. I see that someone has already created a patch, so they can probably work on this :)
|
|
Reporter | |
Comment 5•11 years ago
|
||
(In reply to Jackson Isaac from comment #4)
> Hi David,
>
> I am sorry for inactivity. It would be good if someone else can take this
> up. I see that someone has already created a patch, so they can probably
> work on this :)
No worries :)
Raymond - you should upload a copy of the patch with "r=keeler" in the commit message and then mark this checkin-needed in the keywords: http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed
Flags: needinfo?(mozbugs.retornam)
|
|
Assignee | |
Comment 6•11 years ago
|
||
Done
Attachment #8404983 -
Attachment is obsolete: true
Attachment #8407156 -
Flags: review?(dkeeler)
Flags: needinfo?(mozbugs.retornam)
|
|
Assignee | |
Comment 7•11 years ago
|
||
Keeler please review this and i'll add the check-in needed tag.
|
|
Reporter | |
Comment 8•11 years ago
|
||
Comment on attachment 8407156 [details] [diff] [review]
bug-934676.patch
Review of attachment 8407156 [details] [diff] [review]:
-----------------------------------------------------------------
In general, you can "carry over r+" from previous reviews if nothing significant has changed, which is the case here :)
Attachment #8407156 -
Flags: review?(dkeeler) → review+
|
|
Reporter | |
Comment 9•11 years ago
|
||
(Although you might change the commit comment to something more like "remove unused variable `extracted' in ClientAuthDataRunnable::RunOnTargetThread")
|
|
Assignee | |
Updated•11 years ago
|
Summary: variable `extracted' unused in ClientAuthDataRunnable::RunOnTargetThread → Remove unused variable 'extracted' in ClientAuthDataRunnable::RunOnTargetThread
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
||
Comment 11•11 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 12•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•