Remove unused variable 'extracted' in ClientAuthDataRunnable::RunOnTargetThread

RESOLVED FIXED in mozilla31

Status

()

defect
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: keeler, Assigned: retornam)

Tracking

unspecified
mozilla31
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment, 2 obsolete attachments)

2095   char* extracted = nullptr;
...
2473   if (extracted) {
2474     PR_Free(extracted);
2475   }
Assignee: nobody → jacksonisaac2008
Status: NEW → ASSIGNED
Jackson, are you still interested in working on this?
Flags: needinfo?(jacksonisaac2008)
Posted patch bug-934676.patch (obsolete) — Splinter Review
Attachment #8404983 - Flags: review?(dkeeler)
Comment on attachment 8404983 [details] [diff] [review]
bug-934676.patch

Review of attachment 8404983 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect - r=me.
Attachment #8404983 - Flags: review?(dkeeler) → review+
Assignee: jacksonisaac2008 → mozbugs.retornam
Flags: needinfo?(jacksonisaac2008)
Hi David,

I am sorry for inactivity. It would be good if someone else can take this up. I see that someone has already created a patch, so they can probably work on this :)
(In reply to Jackson Isaac from comment #4)
> Hi David,
> 
> I am sorry for inactivity. It would be good if someone else can take this
> up. I see that someone has already created a patch, so they can probably
> work on this :)

No worries :)

Raymond - you should upload a copy of the patch with "r=keeler" in the commit message and then mark this checkin-needed in the keywords: http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed
Flags: needinfo?(mozbugs.retornam)
Posted patch bug-934676.patch (obsolete) — Splinter Review
Done
Attachment #8404983 - Attachment is obsolete: true
Attachment #8407156 - Flags: review?(dkeeler)
Flags: needinfo?(mozbugs.retornam)
Keeler please review this and i'll add the check-in needed tag.
Comment on attachment 8407156 [details] [diff] [review]
bug-934676.patch

Review of attachment 8407156 [details] [diff] [review]:
-----------------------------------------------------------------

In general, you can "carry over r+" from previous reviews if nothing significant has changed, which is the case here :)
Attachment #8407156 - Flags: review?(dkeeler) → review+
(Although you might change the commit comment to something more like "remove unused variable `extracted' in ClientAuthDataRunnable::RunOnTargetThread")
done.
Attachment #8407156 - Attachment is obsolete: true
Summary: variable `extracted' unused in ClientAuthDataRunnable::RunOnTargetThread → Remove unused variable 'extracted' in ClientAuthDataRunnable::RunOnTargetThread
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/090ed8ff3c8e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.