934726 - Use CustomEvent in l10n.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::L10n, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

That's an offspring of bug 914414.

We want to use CustomEvent but that requires changes to bto code. We'll deal with this followup bug.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch, gaia part

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch, l10n part

Comment 3

[Staś Małolepszy :stas]

Comment on attachment 8404205 [details] [diff] [review]
patch, l10n part

Review of attachment 8404205 [details] [diff] [review]:
-----------------------------------------------------------------

::: bindings/l20n/runtime.js
@@ +221,5 @@
> +    'detail': {
> +      'language': this.ctx.supportedLocales[0]
> +    }
> +  });
> +  document.dispatchEvent(event);

Changing the origin of the dispatched event will break all the apps that use window.addEventListener('localized'), won't it?

Should we keep window for now and file a follow-up to change it later across all the apps (and their tests!)?j

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

You're right!

I'm going to postpone updating this patch until bug 994459 is fixed. It seems that we may stop relying on this in bto which will make things simpler.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch, l10n part

Updated patch. dispatch on window.

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch, gaia part

Updated patch.

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: pull request

I'll wait for travis and push it if the tests pass.

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

https://github.com/mozilla-b2g/gaia/commit/f84f6232821e42bd425684a7de27a4a2b505843f

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

https://github.com/l20n/l20n.js/commit/c52b341e4101aba6b06d3738443928e7e21fb6a8