Closed Bug 934744 Opened 6 years ago Closed 6 years ago

Make Inspector work remotely with Metro Firefox chrome

Categories

(DevTools :: Inspector, defect)

All
Windows 8.1
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 28

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

(Keywords: dev-doc-complete)

Attachments

(2 files, 2 obsolete files)

It would be awesome if we could use desktop Firefox's Inspector and Style Editor to remotely inspect Metro Firefox chrome.  (They already work for content in Metro Firefox tabs, just not for the browser chrome.)

dcamp informs me that Fallen has a hack to make this work in Thunderbird, which might be useful.
The hack is just adding the style editor and inspector as global actors, see bug 928008.
Attached patch patch (obsolete) — Splinter Review
This is the same approach used for Thunderbird.  Since Metro has only one chrome window, we don't even care that this is limited to a single window.
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Attachment #827437 - Flags: review?(ally)
Attachment #827437 - Flags: feedback?(bbenvie)
I'd suggest adding a comment why this is needed, either pointing here or to bug 928018 so it can be removed later on.
Attached patch patch v2Splinter Review
Added a comment as suggested above (thanks!).
Attachment #827437 - Attachment is obsolete: true
Attachment #827437 - Flags: review?(ally)
Attachment #827437 - Flags: feedback?(bbenvie)
Attachment #827500 - Flags: review?(ally)
Attachment #827500 - Flags: feedback?(bbenvie)
Blocks: 928018
Attached patch default prefs for Metro (obsolete) — Splinter Review
This adds devtools.chrome.enabled to our default prefs (off by default), just to make it more convenient to enable in about:config.

It also cleans up a pref that was added in two different locations in DEBUG builds.
Attachment #827507 - Flags: review?(ally)
Comment on attachment 827500 [details] [diff] [review]
patch v2

Review of attachment 827500 [details] [diff] [review]:
-----------------------------------------------------------------

Straightforward enough, this LGTM.
Attachment #827500 - Flags: feedback?(bbenvie) → feedback+
Comment on attachment 827500 [details] [diff] [review]
patch v2

Review of attachment 827500 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #827500 - Flags: review?(ally) → review+
Comment on attachment 827507 [details] [diff] [review]
default prefs for Metro

Review of attachment 827507 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/profile/metro.js
@@ +14,3 @@
>  #endif
>  
> +pref("devtools.chrome.enabled", false);

Don't we want this enabled when the error console is enabled so we can inspect chrome?
Attachment #827507 - Flags: review?(ally) → feedback+
(In reply to :Ally Naaktgeboren from comment #8)
> Don't we want this enabled when the error console is enabled so we can
> inspect chrome?

Good call; I think it's reasonable to assume anyone using a debug build is probably debugging Firefox.  Fixed.
Attachment #827507 - Attachment is obsolete: true
Attachment #827598 - Flags: review?(ally)
Comment on attachment 827598 [details] [diff] [review]
default prefs for Metro (v2)

Review of attachment 827598 [details] [diff] [review]:
-----------------------------------------------------------------

ship it!
Attachment #827598 - Flags: review?(ally) → review+
https://hg.mozilla.org/mozilla-central/rev/a32da499718d
https://hg.mozilla.org/mozilla-central/rev/8605c64627a2
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
Blocks: 946797
Blocks: 946800
No longer blocks: 946800
Keywords: verifyme
I've set "devtools.chrome.enabled" to "true" in Firefox 28 beta 2 in Desktop mode, on Win 8 64-bit.

Could you please offer some guidance on how to see the Inspector while in Metro mode? Is there a specific shortcut?
Flags: needinfo?(mbrubeck)
(In reply to Manuela Muntean [:Manuela] [QA] from comment #13)
> Could you please offer some guidance on how to see the Inspector while in
> Metro mode? Is there a specific shortcut?

Here are instructions for connecting the Inspector to Firefox for Metro:
https://developer.mozilla.org/en-US/docs/Tools/Remote_Debugging/Firefox_for_Metro

To run both desktop and Metro on a single computer, you'll need these instructions:
https://wiki.mozilla.org/Firefox/Windows_8_Integration#Running_Desktop_and_Metro_Simultaneously
Flags: needinfo?(mbrubeck)
Thanks Matt for the links!

With Firefox 28 beta 4 on Win 8.1 32-bit, I've tried to follow the steps from https://wiki.mozilla.org/Firefox/Windows_8_Integration#Running_Desktop_and_Metro_Simultaneously but without success.

After creating a desktop shortcut for Firefox, I created a new profile named "desktop". Then, I right clicked on the shortcut -> Properties, and introduced -p desktop -no-remote in the Target editbox, after "C:\Users\user\Desktop\28 beta 4\firefox.exe". Then I started Firefox in Desktop mode. (all good until now)

I'm having trouble at step 3, regarding the start of Firefox in Metro mode: I've right clicked in the taskbar the Firefox already open -> Properties, and typed -no-remote in the Target editbox, after "C:\Users\user\Desktop\28 beta 4\firefox.exe". But Metro doesn't start.  I've also tried the ./mach run command in a console, but still Metro doesn't start.

Is there something I'm missing here?
Flags: needinfo?(mbrubeck)
Keywords: verifyme
Flags: needinfo?(mbrubeck)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.