Closed
Bug 934768
Opened 11 years ago
Closed 11 years ago
[e.me] API key change for v1.2
Categories
(Firefox OS Graveyard :: Gaia::Everything.me, defect)
Tracking
(b2g-v1.2 fixed, b2g-v1.3 fixed)
RESOLVED
FIXED
People
(Reporter: ranbena, Assigned: ranbena)
Details
Attachments
(1 file)
233 bytes,
text/html
|
crdlc
:
review+
overholt
:
approval-gaia-v1.2+
|
Details |
Current version of e.me uses an v1.1 api key which needs to be replaced.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → ran
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #827124 -
Flags: review?(crdlc)
Assignee | ||
Updated•11 years ago
|
blocking-b2g: --- → koi?
Updated•11 years ago
|
Attachment #827124 -
Flags: review?(crdlc) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Landed on master https://github.com/mozilla-b2g/gaia/commit/b12d548835f49db65e476311522f1a927ac2ad5f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 3•11 years ago
|
||
On a Keon with Boot2Gecko 1.2.0.0-prerelease 20131104224010 (latest build for that device), the throbber spins infinitely when searching. Is that a fallout of this change or a not related?
Assignee | ||
Comment 4•11 years ago
|
||
I'm not familiar with this build, but if it's running gaia branch v1.2 - then this patch didn't yet make it in. It's currently only on master.
Comment 5•11 years ago
|
||
Triagers would like to know what the user impact is here.
Flags: needinfo?(ran)
Assignee | ||
Comment 6•11 years ago
|
||
No user impact. This is solely to let e.me servers understand which Gaia version they're servicing (a workaround to avoid merging the more complex Bug 910333).
Flags: needinfo?(ran)
Comment 7•11 years ago
|
||
Can we just uplift this patch instead of marking it as a blocker?
Comment 8•11 years ago
|
||
Comment on attachment 827124 [details]
Patch - redirect to github PR
I spoke with Ran via IRC and we agreed to uplift but not block here.
Attachment #827124 -
Flags: approval-gaia-v1.2+
Updated•11 years ago
|
blocking-b2g: koi? → ---
Assignee | ||
Comment 9•11 years ago
|
||
Landed on v1.2 https://github.com/mozilla-b2g/gaia/commit/5e1b999a4213b2069e0b01c2dba17a03e78df86c
Comment 10•11 years ago
|
||
(In reply to Ran Ben Aharon (Everything.me) from comment #9) > Landed on v1.2 > https://github.com/mozilla-b2g/gaia/commit/ > 5e1b999a4213b2069e0b01c2dba17a03e78df86c Setting the branch landing status flag.
status-b2g-v1.2:
--- → fixed
Updated•11 years ago
|
status-b2g-v1.3:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•