934795 - [WAP push][CP] Since USERPIN and NETWPIN are all decimal digit format, suggest default keyboard popping up when PIN request page show is numeric keypad, not QWERTY.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Wappush, defect)

Description

[Enpei]

Attachment: screen shot

Since USERPIN and NETWPIN are all decimal digit, suggest default keyboard popping up when PIN request page show is numeric keypad, not QWERTY.

* Build Number  
Buri              
Gaia:     00cd7534afb8d727531c7a939e54e382b3be713a
Gecko:    http://hg.mozilla.org/mozilla-central/rev/47c8e9b16918
BuildID   20131103040200
Version   28.0a1

* Reproduce Steps
1. Send OTA CP messages to DUT with USERPIN and NETWPIN.
2. Open each message.

* Expected Result
Page requesting users to enter PIN code shows and so does numeric keypad.

* Actual Result
Page requesting users to enter PIN code shows and so does QWERTY keypad.

* Occurrence rate
100%

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

You're right for USERPIN secret but I'm wondering if USERPINMAC secret is also a string of decimal digits. We should not change the keyboard if USERPINMAC secret is not a string of decimal digits. I'll take a look at the OMA-WAP-TS-ProvBoot-V1_1-20090728-A.pdf document.

Comment 2

[Enpei]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #1)
> You're right for USERPIN secret but I'm wondering if USERPINMAC secret is
> also a string of decimal digits. We should not change the keyboard if
> USERPINMAC secret is not a string of decimal digits. I'll take a look at the
> OMA-WAP-TS-ProvBoot-V1_1-20090728-A.pdf document.
Even so is it possible that system would know the type of PIN is to trigger correct keyboard?

Comment 3

[Beatriz Rodríguez [:brg]]

From  OMA-WAP-TS-ProvBoot-V1_1-20090728-A specs:
When presented to the user as well as when used as input to the MAC calculation, the user PIN MUST be a string of ASCII encoded decimal digits (i.e. octets with hexadecimal values 30 to 39).

I am not codec expert sorry, but I guess it means we can use numeric keyboard.

Comment 4

[Pau Masiá [:Pau]]

Attachment: UX Spec. OMA Client Provisioning

UX spec that covers the number pad scenario. Thanks.

Comment 5

[Pau Masiá [:Pau]]

Jenny, could you review the spec please? Thanks!

Comment 6

[Jenny Lee]

Hi Pau, I've sent you my comments via mail, please take a look, thanks!

Comment 7

[Pau Masiá [:Pau]]

Attachment: UX Spec. OMA Client Provisioning

Spec updated.

Comment 8

[Maria Angeles Oteo (:oteo)]

The spec that covers this issue has already been confirmed by Jenny in https://bugzilla.mozilla.org/show_bug.cgi?id=935103#c13, so we can start with the implementation.
Thanks Jenny and Pau for your help!

Comment 9

[Albert [:albert]]

Attachment: Patch

Changed keyboard type for pin input and added a handler to disable accept button when input is empty.

Comment 10

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8489901 [details] [review]
Patch

Looks good to me with just the minor comment I've left on the PR addressed.

Comment 11

[Albert [:albert]]

Comment on attachment 8489901 [details] [review]
Patch

Change from comment 10 and test modified because TBPL failed.

Comment 12

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8489901 [details] [review]
Patch

Excellent, try is also green.

https://tbpl.mozilla.org/?rev=58d7f39d7b839bb4d02335105336c2f48f4fb9dd&tree=Gaia-Try

Can you merge this yourself or shall I do it?

Comment 13

[Albert [:albert]]

(In reply to Gabriele Svelto [:gsvelto] from comment #12)
> Comment on attachment 8489901 [details] [review]
> Patch
> 
> Excellent, try is also green.
> 
> https://tbpl.mozilla.org/
> ?rev=58d7f39d7b839bb4d02335105336c2f48f4fb9dd&tree=Gaia-Try
> 
> Can you merge this yourself or shall I do it?

I can, thank you

Comment 14

[Albert [:albert]]

Master: https://github.com/mozilla-b2g/gaia/commit/9cab72d6a077366aaafd9de360827b0e40890b19

Comment 15

[Pau Masiá [:Pau]]

Attachment: UX Spec. OMA Client Provisioning

Here I attach the spec already updated. Thanks!

Comment 16

[Jenny Lee]

Looks good,tks

Comment 17

[Juanjo Iglesias]

I have tested using a flame master (Gecko 4440a99 Gaia e920d2d) and it works correctly. 

When the user has to write the PIN code, page requesting users to enter PIN code shows numeric keypad.

Comment 18

[Beatriz Rodríguez [:brg]]

Thanks everyone for the work done here. Bug marked as verified.