Closed
Bug 934866
Opened 12 years ago
Closed 12 years ago
nsFont::systemFont should be a bool
Categories
(Core :: Graphics: Text, defect)
Core
Graphics: Text
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: heycam, Assigned: heycam)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
823 bytes,
patch
|
jtd
:
review+
|
Details | Diff | Splinter Review |
We store true/false in nsFont::systemFont, and I suspect it is a uint8_t only because it used to be a PRBool which would have been 32 bits.
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Comment 2•12 years ago
|
||
Comment on attachment 827217 [details] [diff] [review]
patch
It appears this came from the PRUint conversion over to standard types. My guess is that this was a byte to assure nice alignment within the struct. But it's definitely passed along to gfxFontStyle as a bool.
Attachment #827217 -
Flags: review?(jdaggett) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•