Closed Bug 934866 Opened 10 years ago Closed 10 years ago

nsFont::systemFont should be a bool

Categories

(Core :: Graphics: Text, defect)

Product:
Core
Component:
Graphics: Text
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla28

People

(Reporter: heycam, Assigned: heycam)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

patch
823 bytes, patch
jtd
: review+
Details | Diff | Splinter Review 
We store true/false in nsFont::systemFont, and I suspect it is a uint8_t only because it used to be a PRBool which would have been 32 bits.
Attached patch patch — — Splinter Review 
Assignee: nobody → cam
Status: NEW → ASSIGNED

        Attachment #827217 -
        Flags: review?(jdaggett)

    
    

    
  
Comment on attachment 827217 [details] [diff] [review]
patch

It appears this came from the PRUint conversion over to standard types.  My guess is that this was a byte to assure nice alignment within the struct.  But it's definitely passed along to gfxFontStyle as a bool.

        Attachment #827217 -
        Flags: review?(jdaggett) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/c766a6fe4ffd
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

    
  
Whiteboard: [qa-]

          You need to log in
          before you can comment on or make changes to this bug.