[app manager] Closing a debugged app from the device closes all the toolbox

RESOLVED FIXED in Firefox 28

Status

RESOLVED FIXED
5 years ago
8 months ago

People

(Reporter: paul, Assigned: ochameau)

Tracking

Trunk
Firefox 28
x86
All
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
STR:
- open a toolbox for "settings"
- open a toolbox for "gallery"
- on the device, close "settings"

Result:
- the 2 toolboxes are closed
(Assignee)

Comment 1

5 years ago
Created attachment 828124 [details] [diff] [review]
Prevent closing all targets when receiving one tabDetached event
(Assignee)

Comment 2

5 years ago
Comment on attachment 828124 [details] [diff] [review]
Prevent closing all targets when receiving one tabDetached event

The issue was that we now instanciate multiple TabTarget per connection
and target.js code wasn't filtering tabDetached event to ensure that it was dispatched on the expected TabActor.
Attachment #828124 - Flags: review?(past)
(Reporter)

Comment 3

5 years ago
Will this need to be uplifted to 1.2?
(Assignee)

Comment 4

5 years ago
No, that's a UI/client patch only.
Uplift would only for seeing it fixed on firefox 25-27 instead of waiting for 28.
Assignee: nobody → poirot.alex
Comment on attachment 828124 [details] [diff] [review]
Prevent closing all targets when receiving one tabDetached event

Review of attachment 828124 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #828124 - Flags: review?(past) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/3179ecb5f410
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/3179ecb5f410
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28

Updated

8 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.