934908 - When you want to change the Wallpaper second times, it doesn't work

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Al Tsai [:atsai]]

You cannot select wallpaper after the first time you changed it.

STR:
1. Long tap on the homescreen
2. Select Wallpaper
3. Choose any wallpaper
4. Long tap on the homescreen
5. Select Wallpaper

Expected Result:
*. I can change the wallpaper

Actual Result:
*. I cannot change the wallpaper.

** The case is by the testing on Flatfish devices. It might not be able to reproduce on other mobile devices **

Gaia:     ac7cf6a73231b3e30fb065c2f38f69c4f5926caa
Gecko:    facaf2461856789476876566b60b5af461a59b79
BuildID   20131105111940
Version   28.0a1

Comment 1

[Al Tsai [:atsai]]

Still reproducible in the daily build.

Gaia:     e95ab38f3c7ea2834e92f4ff37143432f0312a71
Gecko:    7a9d20c22caf534b027f69ffd5e4a274be8c66b7
BuildID   20131106064537
Version   28.0a1

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

I can reproduce it on mobile, too. The second pick activity seems to fail very quickly, event we have select any picture.

Comment 3

[[e-mail]]

I can reproduce it on mobile, too. Seems not a Flatfish only issue

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

When I check the Wallpaper instance, I found a that the second activity message is sent to the previous Wallpaper instance.

The following is the first activity message, syntax is instance: {id} @: {time}:
E/GeckoConsole( 6005): Content JS LOG at app://wallpaper.gaiamobile.org/js/pick.js:7 in wallpaper_init: init, instance:  1383798804039  @: 1383798804227
E/GeckoConsole( 6005): Content JS LOG at app://wallpaper.gaiamobile.org/js/pick.js:46 in wallpaper_startPick: startPick, instance:  1383798804039  @: 1383798804312

The following is the second activity message
E/GeckoConsole( 6005): Content JS LOG at app://wallpaper.gaiamobile.org/js/pick.js:46 in wallpaper_startPick: startPick, instance:  1383798804039  @: 1383798820928
E/GeckoConsole( 6005): Content JS LOG at app://wallpaper.gaiamobile.org/js/pick.js:7 in wallpaper_init: init, instance:  1383798821226  @: 1383798821292

We can find the sequence of startPick and init is reversed and the second startPick is dispatched to the first instance.

The same symptom is also happened to Camera app and Gallery app.

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

put qawanted to find out the regression window

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Note:
1. Add bookmark in browser seems work even launched second time.
2. It seems the failure occurs once activity is succeeded once in homescreen......?

Comment 7

[John Hu [:johnhu][:johu][:醬糊小弟]]

Yes, right.

I also tested pick activity from UI tests app. They works correctly multiple times, but only failed in homescreen.

Unassign myself to find someone who is capable to solve it.

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Changed to general temporarily since it looks like a gecko issue.
I don't get any activitydone event when the second activity does postError/postResult.

Comment 9

[John Hu [:johnhu][:johu][:醬糊小弟]]

Alive,

From the view of wallpaper app, we found the second pick activity is dispatched to the first instance of wall perp. But the UI shows the second instance of wallpaper. When UI shows up and no pick activity, no event is hooked to the UI of second instance and no more postError or postResult sent. See the log in comment 4.

I feel this may be caused by that the activity close procedure doesn't free the first activity window.

Comment 10

[Jason Smith [:jsmith]]

Removing flatfish flags as this is a general regression, not specific to flatfish.

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to John Hu [:johnhu] from comment #9)
> Alive,
> 
> From the view of wallpaper app, we found the second pick activity is
> dispatched to the first instance of wall perp. But the UI shows the second
> instance of wallpaper. When UI shows up and no pick activity, no event is
> hooked to the UI of second instance and no more postError or postResult
> sent. See the log in comment 4.
> 
> I feel this may be caused by that the activity close procedure doesn't free
> the first activity window.

Looks like the first frame is not removed correctly. But I don't know why now...
Thanks!

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: Fix homescreen as activity caller

Fix homescreen reference problem as an activity caller.

Comment 13

[Jason Smith [:jsmith]]

Talked w/Alive in person - this bug only applies to 1.3 & is caused by bug 911053, so we know the regressing bug in this case.

Comment 14

[(inactive after 6/18) Alive Kuo [:alive]]

Merging because I don't think test failed is caused by this -- but ready to backout if so.
https://github.com/mozilla-b2g/gaia/commit/b753e2666986710baaf91c1bec41fd70c49f9f92