93491 - client.mk: libpr0n doesn't get reset to trunk by -PA

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P4)

Description

[Randell Jesup [:jesup] (needinfo me)]

If you follow the direction on the mozilla.org CVS webpage to take a tarball and
reset it to the trunk, you end up doing this:

   then run ``make -f mozilla/client.mk checkout MOZ_CO_FLAGS=-PA''

That resets Seamonkey to the trunk - but not other things, and in particular it
doesn't reset modules/libpr0n.  I chased this for 1 week on and off.

To repeat: install 0.9.2 tarball.  Use the two commands on the CVS web page to
update it to the trunk.  Try to build it.  Fails in nsHTMLImageElement.cpp due
to an interface change in libpr0n.  If you force a -A checkout of libpr0n it
works again.  There may be other modules that aren't reset by that command; I
see a number of -P's when I run the checkout command.

We probably need a CO_FLAGS or GLOBAL_CO_FLAGS that gets applied to everything
(or rewrite the webpage).

Comment 1

[cls]

In the meantime, use 'make -f client.mk CVS_CO_DATE_FLAGS=-PA'

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Accessibility and gfx2 seem to have the same problem

Comment 3

[cls]

Attachment: Use MOZ_CO_FLAGS to override _CO_FLAGS as necessary

Comment 4

[Daniel (Leaf) Nunes]

Hmm. Doesn't this have the side-effect of causing all modules to be pulled from 
MOZ_CO_TAG, if it's defined, even if you have NSPR_CO_TAG defined as well?

Comment 5

[Daniel (Leaf) Nunes]

nevermind, i have obviously not had enough caffeine this morning.
r=leaf

Comment 6

[cls]

Patch checked in.