934924 - checking EI_ABIVERSION for jb4.2.2 build

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[thomas tsai]

Attachment: 0001-checking-EI_ABIVERSION-for-jb4.2.2-build.patch

only jb4.2.2 tool chain needs to check.

Comment 1

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: bug-934924-fix.patch

Checking EI_ABIVERSION for jb4.2.2 build to prevent build failed.

Comment 2

[Kai-Zhen Li [:seinlin][:kli]]

Try server result:
https://tbpl.mozilla.org/?tree=Try&rev=63ac5699ba79

Comment 3

[Benoit Girard (:BenWa)]

Comment on attachment 827328 [details] [diff] [review]
bug-934924-fix.patch

Review of attachment 827328 [details] [diff] [review]:
-----------------------------------------------------------------

jld knows this code better.

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Comment on attachment 827328 [details] [diff] [review]
bug-934924-fix.patch

Review of attachment 827328 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know why some Android versions don't define EI_ABIVERSION, but in any case it seems unlikely that skipping this check (but still checking the rest of the ELF header) would cause problems.

Comment 5

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: bug-934924-fix-2.patch

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/7790a00aab52

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7790a00aab52