[Calendar] Update Drawer Visual Design

RESOLVED FIXED

Status

Firefox OS
Gaia::Calendar
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: epang, Assigned: Casey Yee)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, jian)

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Created attachment 827371 [details]
calendar-drawer.png

Update the Visual Design of the Drawer.
See attached image.
(Assignee)

Comment 1

5 years ago
Created attachment 827720 [details] [review]
Patch for Gaia/master
Attachment #827720 - Flags: review?
(Assignee)

Updated

5 years ago
Attachment #827720 - Flags: review?(pivanov)
Attachment #827720 - Flags: review?(jrburke)
Attachment #827720 - Flags: review?
(Assignee)

Comment 2

5 years ago
Created attachment 827724 [details]
bug-934977.jpg

Screen capture of patch along with header bb changes from Bug 925929.
Comment on attachment 827720 [details] [review]
Patch for Gaia/master

Looks OK for me. Thanks Casey :)
Attachment #827720 - Flags: review?(pivanov) → review+
Comment on attachment 827720 [details] [review]
Patch for Gaia/master

Good for me, but also expecting this code will change when drawer behaviors are changed, so best to land this first, as long as Travis is green in the pull request. Sometimes just restarting the job fixes it, which I expect in this case.
Attachment #827720 - Flags: review?(jrburke) → review+
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

5 years ago
(In reply to James Burke [:jrburke] from comment #4)
> Comment on attachment 827720 [details] [review]
> Patch for Gaia/master
> 
> Good for me, but also expecting this code will change when drawer behaviors
> are changed, so best to land this first, as long as Travis is green in the
> pull request. Sometimes just restarting the job fixes it, which I expect in
> this case.

Hey Casey, have you landed this?
Flags: needinfo?(kyee)
(Assignee)

Comment 6

5 years ago
Yes, and I should have posted the commit:
https://github.com/mozilla-b2g/gaia/commit/3ff762581f51f0f8250d93287a137ebcbae38b9a
Flags: needinfo?(kyee)
You need to log in before you can comment on or make changes to this bug.