New event entry pane needs some styling love

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: daleee, Assigned: jr_r123)

Tracking

Details

(Whiteboard: frontend, postfest, [mentor=k88hudson])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Updated

5 years ago
Whiteboard: frontend, postfest
(Reporter)

Updated

5 years ago
Assignee: nobody → jr_r123
(Reporter)

Updated

5 years ago
Whiteboard: frontend, postfest → frontend, postfest, [mentor=daleee]
(Assignee)

Updated

5 years ago
Attachment #8343596 - Attachment description: new look → new look https://github.com/jrromasanta1/webmaker.org
(Reporter)

Comment 2

5 years ago
Comment on attachment 8343596 [details]
new look https://github.com/jrromasanta1/webmaker.org

Moving this review on to Kate as it is designed related.
Also, posting a direct link to your code / branch you worked on instead of just your fork of the GitHub repo would be helpful.
Attachment #8343596 - Flags: review?(dale) → review?(kate)
(Reporter)

Updated

5 years ago
Whiteboard: frontend, postfest, [mentor=daleee] → frontend, postfest, [mentor=k88hudson]
This needs to be done as a proper pull request, an attachment created, and then a reviewer set (Dale or Kate likely).
Status: NEW → ASSIGNED
Actually, apologies, I see you've done this.  Kate, what's up with this review?
Flags: needinfo?(kate)
Sorry.. I don't see the pull-request, maybe I am totally missing something? Would you mind posting it again?
Flags: needinfo?(kate) → needinfo?(jr_r123)
(Assignee)

Comment 7

5 years ago
What do you mean?
Here is the fork with me changes
https://github.com/jrromasanta1/webmaker.org/blob/master/views/events/map.html
https://github.com/jrromasanta1/webmaker.org/blob/master/public/css/events/map/create.less

Sorry. I am kind confused. Can someone tell me the proper way of submitting.
Flags: needinfo?(jr_r123)
You need to create a pull-request from your branch: (instructions here: https://help.github.com/articles/creating-a-pull-request)

This will give you a page that looks like this(https://dl.dropboxusercontent.com/spa/udzcfdb4yizzlua/3swz5zz3.png) , so we can look at a comparison of the code changes.

You should get a url that looks like https://github.com/mozilla/webmaker.org/pull/xxxx. Paste that URL in the attachment, and flag me for review.

Thanks!
Flags: needinfo?(jr_r123)
(Assignee)

Comment 9

5 years ago
Created attachment 8348993 [details] [review]
Events create new look
Attachment #8343596 - Attachment is obsolete: true
Attachment #8343596 - Flags: review?(kate)
Attachment #8348993 - Flags: review?(kate)
Attachment #8348993 - Flags: feedback+
Flags: needinfo?(jr_r123)
(Assignee)

Comment 10

5 years ago
Hi Kate, Can you please check this PR before Jan 7 so I can pass my course. It would be very grateful
Flags: needinfo?(kate)
This was solved by changes landed by Dale
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: needinfo?(kate)
Resolution: --- → WONTFIX
(Assignee)

Comment 12

5 years ago
I do not see dale's changes that resolve the changes I made. Please reply
Flags: needinfo?(kate)
Comment on attachment 8348993 [details] [review]
Events create new look

Sorry, I mixed this up with another ticket. This is great, R+

I'll land on master
Attachment #8348993 - Flags: review?(kate) → review+
Flags: needinfo?(kate)

Comment 14

5 years ago
Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/0286653be61fbc681f16d64cac5f267f14ba8f27
Bug 935005 - New event entry pane needs some styling love

Bug 935005 - New event entry pane needs some styling love
Resolution: WONTFIX → FIXED
You need to log in before you can comment on or make changes to this bug.