Closed
Bug 935014
Opened 10 years ago
Closed 9 years ago
Merge the Simulator and b2g-desktop
Categories
(DevTools Graveyard :: WebIDE, defect)
DevTools Graveyard
WebIDE
Tracking
(firefox30 fixed, firefox31 fixed, b2g-v1.4 fixed, b2g-v2.0 fixed)
RESOLVED
FIXED
Firefox 31
People
(Reporter: ochameau, Assigned: ochameau)
References
(Depends on 1 open bug, )
Details
Attachments
(1 file)
2.26 KB,
patch
|
fabrice
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
We have various ways to run Gaia on desktop, with various subtle differences. We should aim to merge all experiences on desktop to one environment. We can easily start by merging b2g desktop and the simulator. It will be about merging "prosthesis", the b2g desktop addon that simulator uses to fix various stuff being broken in b2g desktop, but also to add various features without introducing risk to the product. It will be also about ensuring that the simulator and b2g desktop uses the same gaia profile, built with the same configuration. Then, it should be easy to also move the simulator addon itself to mozilla-central. This addon is mainly a build script that package b2g desktop and gaia profile into a xpi. This addon then just register to the firefox app manager in order to run b2g desktop with the gaia profile on demand. Once we will have done that, we can build the addon when building b2g target so that we get simulator builds for free when we build b2g desktop.
Assignee | ||
Comment 1•9 years ago
|
||
This simple patch is meant to replace bug 942756 on 1.4 branch. I wish we could uplift the UI patches I recently landed in bug 944443, and this patch, so that we could spawn 1.4 simulator builds out of mozilla-central! Bug 920198 is going to turn on FXOS_SIMULATOR build variable, so that b2g desktop UI tweaks for phones will be on our builds. It will also ensure building simulator xpis during b2g desktop builds. My plan is to land this patch and bug 920198 shortly, then let this bake on master and uplift.
Assignee | ||
Updated•9 years ago
|
Attachment #8395670 -
Flags: review?(fabrice)
Updated•9 years ago
|
Attachment #8395670 -
Flags: review?(fabrice) → review+
Assignee | ||
Comment 2•9 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=63fa9fbb9a7c
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → poirot.alex
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/8b1a3307065a
Status: NEW → ASSIGNED
Keywords: checkin-needed
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8b1a3307065a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8395670 [details] [diff] [review] Allows to specify the devtool debuggger port via the command line. See bug 976773 comment 30. We would like to build 1.4 simulators and need to uplift mostly desktop-specific patches. This patch modify only desktop codepath.
Attachment #8395670 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Attachment #8395670 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 6•9 years ago
|
||
This doesn't apply to Aurora in ways that scream other dependencies.
status-b2g-v1.4:
--- → affected
status-b2g-v2.0:
--- → fixed
status-firefox30:
--- → affected
status-firefox31:
--- → fixed
Flags: needinfo?(poirot.alex)
Keywords: branch-patch-needed
Assignee | ||
Comment 7•9 years ago
|
||
Yes, it depends on another patch that is a+. You may have seen a bunch of patches from me to land in 1.4. I drafted an order list of these patches in bug 976773 comment 30. Before asking for a? I didn't knew I could have merged all patches into a single one... tell me if I should do that now to help the uplift. Otherwise you should be able to checkin all these patches correctly with the given order. There is only one patch that requires a 1.4-specific version, it is bug 990057, specific in comment 31. There is a specific patch in the bug.
Flags: needinfo?(poirot.alex)
Comment 8•9 years ago
|
||
Ah, the problem is that the other bugs weren't showing up in the bug query I used. Makes more sense now :)
Updated•5 years ago
|
Product: Firefox → DevTools
Updated•3 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•