935018 - Data fields doesn't disappear after selecting "All Events"

Status: VERIFIED FIXED

(Mozilla Reps Graveyard :: reps.mozilla.org, task)

Comment 1

[Michał Frontczak [:fxa90id] ♥]

I couldn't find what is wrong (js code is to big for me), maybe someone else will take a look on this bug.

Comment 2

[Karan Agarwal [:karanagarwal17]]

hey Michal,
I had a look at the matter. i don't think it is a bug. 

First of all, what i think you are talking about are advance options which can be hidden very easily, using the icon in the right of all events.

And the data fields allow us to refine the selected fields (for eg. "past"), so i think they are necessary if the user wants to refine his search results for "all events".

What do you think ?

Comment 3

[Michael Kohler [:mkohler]]

As far as I can see the following happens:

1) You select "Custom"
2) The filters appear
3) You select "All" or any other value of the dropdown
4) The filters don't disappear even though they were not displayed at the beginning

This might be a minor inconvenience since you'll need a second click on the icon to make them disappear.

I might even go that far and suggest to have the filters enabled by default. Even for "Current and Future" it makes sense to further filter the results.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/d82bcfe4e933034296c54be711d26f3cadbf6a3a
[Bug 935018] Data fields doesn't disappear after selecting All Events

https://github.com/mozilla/remo/commit/c6073bb7b7029a3f62034352be1144ec6e554d3b
Merge pull request #1226 from karanagarwal17/bug-935018-allevents-fix

[Bug 935018] Data fields doesn't disappear after selecting All Events

Comment 5

[John Giannelos [:nemo-yiannis]]

Verified on stage:

* When clicking 'custom' date filters appear
* When clicking any other option date filters hide