Closed Bug 935023 Opened 11 years ago Closed 11 years ago

Dark themes don't work well the grain texture on the folder pane.

Categories

(Thunderbird :: Theme, defect)

x86
All
defect
Not set
normal

Tracking

(thunderbird26 wontfix, thunderbird27 fixed, thunderbird28 fixed, thunderbird_esr24 affected)

RESOLVED FIXED
Thunderbird 28.0
Tracking Status
thunderbird26 --- wontfix
thunderbird27 --- fixed
thunderbird28 --- fixed
thunderbird_esr24 --- affected

People

(Reporter: jsbruner, Assigned: jsbruner)

References

Details

Attachments

(2 files)

Bug 845819 caused a grain texture to be placed on the folderpane. Unfortunately this doesn't work well with many dark themes (since the texture lightens things slightly). Therefore we need to investigate someway to bypass this...
Depends on: 939067
If we don't mind waiting until TB 31, we could probably use CSS blend modes. I expect those will be in Gecko by then.
This patch replaces the existing grain.png with a new noise.png that should work significantly better with dark themes. The effect is much less noticeable, which is actually fine considering folderpanes don't usually have any such effect at all. Just a slight thing more design-aware people will notice.
Assignee: nobody → josiah
Status: NEW → ASSIGNED
Attachment #833100 - Flags: ui-review?(richard.marti)
Attachment #833100 - Flags: review?(richard.marti)
Here's what a dark theme looks like with the new noise on the folder pane. *Much* better I think.
Comment on attachment 833100 [details] [diff] [review]
Switch to a less intense grain overlay

Review of attachment 833100 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, this looks much better. Thanks! r+ui-r=me
Attachment #833100 - Flags: ui-review?(richard.marti)
Attachment #833100 - Flags: ui-review+
Attachment #833100 - Flags: review?(richard.marti)
Attachment #833100 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/65aa591b610e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 28.0
Will this get into TB24.x? As the change was done on TB22 and now users on TB24 are affected and without this fix yet.
Blocks: 949389
Comment on attachment 833100 [details] [diff] [review]
Switch to a less intense grain overlay

[Approval Request Comment]
Regression caused by (bug #): Bug 845819
User impact if declined: Any dark themes the user has installed will suffer from serious color styling. 
Testing completed (on c-c, etc.): Landed on 28.
Risk to taking this patch (and alternatives if risky): CSS change, no risk.

Really should have landed this on an earlier dot release. Forgot to ask for uplift though.
Attachment #833100 - Flags: approval-comm-release?
Comment on attachment 833100 [details] [diff] [review]
Switch to a less intense grain overlay

[Triage Comment]
Ok, lets get it onto beta, and we'll do ESR24 if no issues reported.
Attachment #833100 - Flags: approval-comm-release?
Attachment #833100 - Flags: approval-comm-esr24?
Attachment #833100 - Flags: approval-comm-beta+
Keywords: checkin-needed
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #10)
> https://hg.mozilla.org/comm-central/rev/840b157215fa

This was actually bug 949389.
Attachment #833100 - Flags: approval-comm-esr24? → approval-comm-esr24+
Comment on attachment 833100 [details] [diff] [review]
Switch to a less intense grain overlay

Actually, this didn't apply nicely.
Attachment #833100 - Flags: approval-comm-esr24+ → approval-comm-esr24-
Josiah, is this a problem on ESR, or do we need a ported patch?
Flags: needinfo?(josiah)
Yikes, totally missed this!

So unfortunately the patch fails to apply and can't easily be done because it depends on a *lot* of different bugs/patches (I haven't even found them all). If I create an updated patch will it mess things up later when we actually merge (do we?) into 24?
Flags: needinfo?(josiah) → needinfo?(mbanner)
(In reply to Josiah Bruner [:JosiahOne] from comment #14)
> So unfortunately the patch fails to apply and can't easily be done because
> it depends on a *lot* of different bugs/patches (I haven't even found them
> all). If I create an updated patch will it mess things up later when we
> actually merge (do we?) into 24?

We only merge individual patches into 24 on a what we need basis.
Flags: needinfo?(mbanner)
You need to log in before you can comment on or make changes to this bug.