Remove multi-touch perf opt from MetroInput

RESOLVED FIXED in mozilla28

Status

()

Core
Widget: WinRT
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jimm, Assigned: jimm)

Tracking

26 Branch
mozilla28
x86_64
Windows 8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
This is having an adverse effect on apzc responsiveness. Also I don't think this is needed anymore now that we have the HasPointMoved optimization. 

Another issue is that we delay sending touch moves until the first touch point position has changed, which delays the sending of all touch points.
(Assignee)

Comment 1

5 years ago
Created attachment 827438 [details] [diff] [review]
patch
Assignee: nobody → jmathies
Attachment #827438 - Flags: review?(tabraldes)
Comment on attachment 827438 [details] [diff] [review]
patch

Review of attachment 827438 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

::: widget/windows/winrt/MetroInput.cpp
@@ +572,5 @@
>    touch->mChanged = true;
>    // replacing old touch point in mTouches map
>    mTouches.Put(pointerId, touch);
>  
> +  AddPointerMoveDataToRecognizer(aArgs);

Seems like you could move this above line 565, and remove line 567
Attachment #827438 - Flags: review?(tabraldes) → review+
(Assignee)

Comment 3

5 years ago
updated per comments. 

https://hg.mozilla.org/integration/fx-team/rev/b0c2bafe0fec
https://hg.mozilla.org/mozilla-central/rev/b0c2bafe0fec
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.