935052 - Reduce exposure to launch() method in tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Zac C (:zac)]

We know that launch() is a bit unreliable but similarly we also know that it takes some liberties by launching the app into user focus. This is an un-natural behaviour.

I think as an ongoing task we can slowly migrate some app objects over to use `self.apps.displayed_app` in some cases.

In some cases we will have to retain `launch()` but that is OK.

I'm going to start off with a patch to the gallery app object to show what kind of code and how we should do it all.

Comment 1

[Zac C (:zac)]

Attachment: github pr

Comment 2

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/5663b202d9a901186f3b1037841a855721dd8bca

Comment 3

[Zac C (:zac)]

Leave this open until we clear out as many `launch` from tests and apps as we can :)

Comment 4

[Zac C (:zac)]

I'll work on `Phone` app now

Comment 5

[Zac C (:zac)]

Attachment: github pr

Comment 6

[Bob Silverberg [:bsilverberg]]

As per my email of earlier today: This needs to be flagged for uplifting to v1.2. I think it makes sense to wait for all the apps to be updated, and then attach an additional PR to this bug for all of them in v1.2 at the end. Either that, or attach PRs for each cherry-picked commit as we go.

If we aren't vigilant about this on each and every bug we're going to end up with a mess again very soon.

Comment 7

[Luke Chang [:lchang] (inactive)]

Hi Zac and Bob,

Please refer to following two jobs. We found that Travis CI failed after 83300b7 merged.

9231f8a: https://travis-ci.org/mozilla-b2g/gaia/jobs/13547926
83300b7: https://travis-ci.org/mozilla-b2g/gaia/jobs/13549820

Could you please help check this? Thanks.

Comment 8

[Bob Silverberg [:bsilverberg]]

@Luke, the step that failed in Travis is the CI_ACTION=test_agent step, which has nothing to do with the Python tests that were affected by the merged pull request, so while it's true that Travis failed, it cannot be a result of that commit. I'm not even sure what the test_agent step is doing. Perhaps James can shed some light on that.

Comment 9

[Zac C (:zac)]

Attachment: github pr

Rob I think this better represents the intention of the code here.

See this bug comments for background information about why I'm doing this to the app objects/tests.

Comment 10

[Zac C (:zac)]

Attachment: github pr

Comment 11

[Zac C (:zac)]

Attachment: github pr

Comment 12

[Florin Strugariu [:Bebe]]

merged 
https://github.com/mozilla-b2g/gaia/commit/69c20f0ca276c46a9704214eb994073660f28ad2

Comment 13

[Florin Strugariu [:Bebe]]

Merged in 
https://github.com/mozilla-b2g/gaia/commit/d1b799166e6ad3095784034f4aaa8ff73b09e148

Comment 14

[Robert Wood [:rwood]]

Comment on attachment 830215 [details] [review]
github pr

LGTM (I didn't actually run the code)

Comment 15

[Zac C (:zac)]

Merged endurance tests pull too:

https://github.com/mozilla-b2g/gaia/commit/2c46c4a8f5dd7b593460fdc18a5001a4bc9e7329

Comment 16

[Zac C (:zac)]

Attachment: github pr

Comment 17

[Florin Strugariu [:Bebe]]

retested this and still OK

Comment 18

[Bob Silverberg [:bsilverberg]]

Landed on master in https://github.com/mozilla-b2g/gaia/commit/80889faa46c3ce400cbfa748ce00791d796afcb2

This should be brought over to v1.2 as well.

Comment 19

[Bob Silverberg [:bsilverberg]]

I need this for another commit I'm trying to get into v1.2, so taking this for uplift.

Comment 20

[Bob Silverberg [:bsilverberg]]

Oops, this isn't the one. Letting go for now.

Comment 21

[Viorela Ioia [:viorela]]

Attachment: v1.2 PR: https://github.com/mozilla-b2g/gaia/pull/14069

Comment 22

[Bob Silverberg [:bsilverberg]]

Landed on v1.2 in https://github.com/mozilla-b2g/gaia/commit/e396bf145c0759a5f1830e82853f9c015ad205bf

Comment 23

[Bob Silverberg [:bsilverberg]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14094

Pointer to Github pull-request

Comment 24

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8338996 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14094

Uplift for v1.2

Comment 25

[Bob Silverberg [:bsilverberg]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14095

Pointer to Github pull-request

Comment 26

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8339001 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14095

Uplift for v1.2

Comment 27

[Bob Silverberg [:bsilverberg]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14096

Pointer to Github pull-request

Comment 28

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8339004 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14096

Uplift to v1.2

Comment 29

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8339004 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14096

This landed on v1.2 in https://github.com/mozilla-b2g/gaia/commit/a5269e1fd2efdf714e75531fe76c9871882026ec

Comment 30

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8338996 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14094

Landed on v1.2 in https://github.com/mozilla-b2g/gaia/commit/c387ea866deb393beb99cb8b2c61313bc97dd1f7

Comment 31

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8339001 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14095

Landed on v1.2 in https://github.com/mozilla-b2g/gaia/commit/b7dfbbdca05f83a194b137a75d1bfc17cba04554

Comment 32

[Bob Silverberg [:bsilverberg]]

All the uplifts have landed.