935087 - [Download Manager] Download list view skeleton

Status: RESOLVED DUPLICATE of bug 935088

(Firefox OS Graveyard :: Gaia, defect)

Description

[Cristian Rodriguez (:crdlc)]

Implement the skeleton for our app or settings card (header, main container,...)

Comment 2

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Hi Kaze, this patch includes a new item in the main list to see the downloads. This is just a skeleton including the item in the main list and a new empty card. Are you comfortable with this code? It is the first time I touch in this app. Thanks a lot my mate

Comment 3

[Fabien Cazenave [:kaze]]

Comment on attachment 827657 [details]
Patch v1

Looks good to me.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 827657 [details]
Patch v1

Asking Kaze, as owner to review it.

Accidentally didn't see that you already attached a patch for this, and I came with the excatly same solution.

So if I could do it, I would do a r+, but let ask Kaze for it :)

Also we will need to modify the css to select the correct icon, but first we need that icon (I saw another task for it)

Thanks!

Comment 5

[Fabien Cazenave [:kaze]]

Comment on attachment 827657 [details]
Patch v1

Still looks good to me. :-)

Comment 6

[Cristian Rodriguez (:crdlc)]

Thanks a lot guys!!!

https://github.com/mozilla-b2g/gaia/commit/2c61fbabc936f1477e3b5649e400af8d52ea8bcc

Comment 7

[Evelyn Hung]

Backouted since we don't want to leave a empty page without implementation, that confuses people.
https://github.com/mozilla-b2g/gaia/commit/b824c4ca99bb3e6921dae627cd5ecd6f94cafedf

Another note: please add bug number in your commit message next time. Thanks.

Comment 8

[Evelyn Hung]

(In reply to Evelyn Hung [:evelyn] from comment #7)
> Backouted since we don't want to leave a empty page without implementation,
> that confuses people.

bug 935082 seems to be the implementation of this page, I suggest to close this bug and move/merge this patch there.

Comment 9

[Cristian Rodriguez (:crdlc)]

Sorry I forgot the number although I don't understand what you did here, we were in the middle of the spring thought and it was landed on master (AFAIK the development branch). Who people are confused in master?

Comment 10

[Evelyn Hung]

(In reply to Cristian Rodriguez (:crdlc) from comment #9)
> Sorry I forgot the number although I don't understand what you did here, we
> were in the middle of the spring thought and it was landed on master (AFAIK
> the development branch). Who people are confused in master?

Some complains on dev-gaia caught my attention on this bug. Usually, when we close to FC date, landing partial work may be risky because if the feature can't be implemented in time, we have to push back the schedule and backed out all merged commits before branching out. Maybe this is not that dangerous case (we have one month to reach v1.3 FC date, 12/8), but I still hope we can keep Settings app in a functional stable state.

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Evelyn Hung [:evelyn] from comment #10) 
> Some complains on dev-gaia caught my attention on this bug. Usually, when we
> close to FC date, landing partial work may be risky because if the feature
> can't be implemented in time, we have to push back the schedule and backed
> out all merged commits before branching out. Maybe this is not that
> dangerous case (we have one month to reach v1.3 FC date, 12/8), but I still
> hope we can keep Settings app in a functional stable state.

Hi Evelyn,

thanks for your comments and support with settings app.

We landed that part cause we were following the pattern of landing small pieces of code that are functional. Right now this commit was adding a new panel, functional, yes just the panel, but not breaking the app.

As well reviewed by the owner of the module, but as you commented, and following your suggestions will land more bugs in a row to provide more functionality there.

Thanks a lot!

Comment 12

[Borja Salguero [:borjasalguero]]

This work is included in bug 935088.