935145 - Pop-up type field is empty by default in non-English versions

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Igor Entaltsev [:igoryen]]

1) Popcorn
2) Set a non-English locale. 
3) Add a pop-up event
4) The Popup's Type (Тип) input field is empty by default (should be 'Popup').
https://dl-web.dropbox.com/spa/49xeskca52abzlc/p1z6agu2.png

Comment 1

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/366

Comment 2

[Scott [:thecount] Downe]

I am not able to reproduce this on master.

Comment 3

[Scott [:thecount] Downe]

Comment on attachment 8343205 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/366

So, looks like this is chrome only.

I wonder why? I suspect their might be a better fix once we know more about this.

Sounds like there is more going on, and we're just correcting the symptom.

Comment 4

[Scott [:thecount] Downe]

Comment on attachment 8343205 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/366

So after a bit of help, the issue here is if we translate that value too soon, it won't match any of the select values, thus it doesn't properly find the select default because type just so happens to have a value in the translation files, so we incorrectly pick it up and translate it too soon, then try to set the default to a translated value, but the keys for the select option are stored in english.

Firefox just so happens to default the first drop down if it doesn't have one, so it looks like it works.

We probably shouldn't be using translated values as identifies, and that was not intended, so this patch actually feels pretty sane.

Just add a comment.

Comment 5

[Ali Al Dallal [:alicoding]]

merged https://github.com/alicoding/popcorn.webmaker.org/commit/f0d7be7157a8372826c34e3e0353dd2250378048