935189 - Use OS.File to remove directories recursively

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

Now the dependant bugs are fixed we can remove a bunch of unnecessary code.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Having different OS.File methods depending on whether we're removing a directory is a little annoying and I'd rather test and call the right one rather than assume since if this goes wrong all sorts of things break.

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 827709 [details] [diff] [review]
patch rev 1

Review of attachment 827709 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/extensions/XPIProvider.jsm
@@ +1387,2 @@
>      }
>      catch (e if e instanceof OS.File.Error && e.becauseNoSuchFile) {

Don't need this try/catch anymore either, as both methods support an ignoreAbsent flag.

AFAIK that flag is meant to default to true, but it currently defaults to false for removeDir() - filed bug 935792.

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 827709 [details] [diff] [review]
patch rev 1

(In reply to Blair McBride [:Unfocused] from comment #2)
> Comment on attachment 827709 [details] [diff] [review]
> patch rev 1
> 
> Review of attachment 827709 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: toolkit/mozapps/extensions/XPIProvider.jsm
> @@ +1387,2 @@
> >      }
> >      catch (e if e instanceof OS.File.Error && e.becauseNoSuchFile) {
> 
> Don't need this try/catch anymore either, as both methods support an
> ignoreAbsent flag.
> 
> AFAIK that flag is meant to default to true, but it currently defaults to
> false for removeDir() - filed bug 935792.

It's still needed for the OS.File.stat call I can pull the remove calls outside of the try...catch block and set ignoreAbsent on them if you want though

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 827709 [details] [diff] [review]
patch rev 1

Review of attachment 827709 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, duh.

Comment 5

[Dave Townsend [:mossop]]

https://hg.mozilla.org/integration/fx-team/rev/7cefaf69392d

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7cefaf69392d