935274 - Getting wrapper (and preserving its color) from nsIHTMLCollection is slow

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

The patch should cut few % of the Bug 916851's testcase.
(Although profiling is currently a bit difficult because of the regression from bug 932322)

Trying to be consistent both in style and order of method declarations.

https://tbpl.mozilla.org/?tree=Try&rev=4383fca102db

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Looks like I had pushed from broken m-i to try :/

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 827682 [details] [diff] [review]
patch

Needs some MOZ_OVERRIDE stuff on the subclasses, right?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: with MOZ_OVERRIDE

(I'm not a huge fan of MOZ_OVERRIDE, at least yet)

Comment 4

[Peter Van der Beken [:peterv]]

Comment on attachment 827682 [details] [diff] [review]
patch

Review of attachment 827682 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsContentList.h
@@ +248,5 @@
>    virtual ~nsContentList();
>  
>    // nsWrapperCache
>    using nsWrapperCache::GetWrapperPreserveColor;
> +  virtual JSObject* WrapObject(JSContext* Cx,

aCx?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: aCx

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

https://tbpl.mozilla.org/?tree=Try&rev=96479e632c7d

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v2

Er, this is with MOZ_OVERRIDE
https://tbpl.mozilla.org/?tree=Try&rev=fb0303713a64

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/da183762a54c

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/da183762a54c