Closed Bug 935289 Opened 11 years ago Closed 10 years ago

Update about:home thumbnail context menu items


(Firefox for Android Graveyard :: Awesomescreen, defect)

Not set


(Not tracked)



(Reporter: Margaret, Unassigned, Mentored)



(Whiteboard: [lang=java][bad first bug])

From the mockup in bug 931021:

Some string changes:
* "Open in New Tab" -> "Open in new tab"
* "Open in Private Tab" -> "Open in private tab"

Some functional changes:
* Get rid of current "Pin Site"/"Unpin Site"/"Edit" items
* For unpinned thumbanails: "Add a pin…" item, which opens new "Add a pin" dialog
* For pinned thumbnails: "Edit pin…", which opens new "Edit pin" dialog

I'll deal with adding the "Remove" item in bug 913457.
I'm going to deal with the "Remove" item for thumbnails in bug 913457.
HEy can i work on this bug???
(In reply to Jayesh from comment #1)
> HEy can i work on this bug???

Hey Jayesh, I appreciate your enthusiasm, but I'm already working on a patch for this bug myself :)

Usually, when someone is in the "Assigned To:" field of a bug, it means they're working on it. However, if it's been a long time since there's been any activity, you can usually ask to take it over.
I haven't had time to work on this myself, but a fix here is somewhat complicated, since it requires changing the pin site dialog. To fix this, I'd actually like to see us re-purpose the "Edit Bookmark" dialog to take care of editing pinned sites as well.

I'm marking this as a mentor bug because I think it would be a good project for someone, but it's definitely not a good first bug.
Assignee: margaret.leibovic → nobody
Whiteboard: [mentor=margaret][lang=java][bad first bug]
Mentor: margaret.leibovic
Whiteboard: [mentor=margaret][lang=java][bad first bug] → [lang=java][bad first bug]
The world had changed since this bug was filed, and this will require UX attention if we want to change the pin site dialog. I think we should just file a new bug if we ever decide to make a push to improve the top sites panel.
Closed: 10 years ago
Resolution: --- → WONTFIX
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.