Closed Bug 935297 Opened 6 years ago Closed 6 years ago

Add Moz2D API to stream paths into an arbitrary sink

Categories

(Core :: Graphics, defect)

x86_64
Windows 8
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: bas.schouten, Assigned: bas.schouten)

References

(Blocks 1 open bug)

Details

(Whiteboard: [qa-])

Attachments

(5 files)

We should add an API to stream paths into an arbitrary sinks. This will make it easier for backends to use path objects across backends if so desired, as well as allow a more elegant (more cross-backend) implementation of path flattening.
Blocks: 935049
Attachment #827714 - Flags: review?(matt.woodrow)
Attachment #827714 - Flags: review?(matt.woodrow) → review+
Attachment #827746 - Flags: review?(matt.woodrow)
Attachment #827747 - Flags: review?(matt.woodrow)
Attachment #827748 - Flags: review?(matt.woodrow)
Attachment #827746 - Flags: review?(matt.woodrow) → review+
Attachment #827747 - Flags: review?(matt.woodrow) → review+
Attachment #827748 - Flags: review?(matt.woodrow) → review+
Attachment #827714 - Flags: checkin+
Attachment #827746 - Flags: checkin+
Attachment #827747 - Flags: checkin+
Attachment #827748 - Flags: checkin+
Comment on attachment 827777 [details] [diff] [review]
Part 5: Implement StreamToSink on CG.

Review of attachment 827777 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/PathCG.cpp
@@ +172,5 @@
> +  switch (element->type) {
> +    case kCGPathElementMoveToPoint:
> +      {
> +        CGPoint pt = element->points[0];
> +        sink->MoveTo(Point(pt.x, pt.y));

Please add a helper like CGPointToPoint or something along those lines so we can prevent all these ugly temps :).
Attachment #827777 - Flags: review+
Attachment #827777 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/67a25599600e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.