935307 - [B2G][Contacts] A user is able to retrieve a contact information from "Settings" screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[sarsenyev]

Attachment: IMG_0348.MOV

Description:
Tapping on the bottom of the "Settings" screen retrieves a contact information screen

Prerequisites:
Have some contacts in the "Contacts" app

Repro Steps:
1) Updated Burito BuildID: 20131103004003
2) Open "Contacts" app from the home screen
3) Navigate to "Settings"
4) Tap on the bottom of the screen

Actual:
The Contact screen information screen pops up

Expected:
User cannot retrieve any pages from "Settings" unless tapping the option bar

Environmental Variables:
Device: Buri 1.2 COM RIL
BuildID: 20131103004003
Gaia: cb981e2f47bc644b4d178d54378c3676c946facf
Gecko: eec4da1b27eb
Version: 26.0
Firmware Version: US_20131015
RIL Version: 01.01.00.019.264


Notes:
Repro frequency: 100%

See attached: video

Comment 1

[sarsenyev]

The issue doesn't reproduce on 1.1 during a different design on the "Contacts Settings" page

Comment 2

[Preeti Raghunath(:Preeti)]

QA,

Please keep an eye out for similar activity on other areas. 

But, will be a blocker for regression.

Comment 3

[sarsenyev]

The regression window:

The last working build:
Device: Buri 1.2 Central build
BuildID: 20130821050136
Gaia: 70033ba9cbac65551f68fcb3a28f7daf3105e6ff
Gecko: b2486721572e
Version: 26.0a1 
Firmware Version: US_20131015

The issue is reproducible from:
Device: Buri 1.2 Central build
BuildID: 20130822040202
Gaia: abd81ff5e49bf0c9479cdc5c5eb6975cc776f632
Gecko: 2ab07dec6404
Version: 26.0a1
Firmware Version: US_20131015

Comment 4

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: 13569.html

Comment 5

[Germán Toro del Valle (:gtorodelvalle)]

There are a couple of Marionette test cases failing (https://travis-ci.org/mozilla-b2g/gaia/jobs/13801143) and I am currently trying to figure out the best way to solve this :-) Any help is more than appreciated!

Comment 6

[Germán Toro del Valle (:gtorodelvalle)]

Hi Kevin, would you mind having a look at https://github.com/mozilla-b2g/gaia/pull/13569 ? There is some issue related to this patch regarding the Marionette test cases I need support with, please :-) Thanks!

Comment 7

[Germán Toro del Valle (:gtorodelvalle)]

Damn it! I forgot to need-info you :-(

Comment 8

[Kevin Grandon :kgrandon]

After a quick 30 second look it appears it's timing out because the #view-contact-form pane is not reaching a location.y === 0. If any of your classes change that, it may not work. I will try applying your patch and running the tests later.

Leaving needinfo up so I can look at this more in-depth.

Comment 9

[Jose Manuel Cantera]

Comment on attachment 830207 [details]
13569.html

good work, thanks!

Comment 10

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/af96c97399b22de754fce06d152fd5b42b262920

Comment 11

[Kevin Grandon :kgrandon]

Backed out for failing tests: https://github.com/mozilla-b2g/gaia/commit/02c078d581911732884a98757dacb4da165df5ce

I'll look into this shortly. We either need to fix the tests or commit before landing. It's very likely that the tests need to be updated.

Comment 12

[Kevin Grandon :kgrandon]

Attachment: Travis test failures

Here's the current test failure log.

Comment 13

[Kevin Grandon :kgrandon]

Attachment: Gaia patch - Contacts testing updates

This pull request comes with the original commit and a few fixes for tests.

Comment 14

[Kevin Grandon :kgrandon]

The changes to the tests simply wait for the animation to complete before accessing elements. I think before these changes it was waiting for the dom element - and accessing that. I think that the block-item having pointer-events of none is screwing this up.

Anyway - if either of you two could review this patch, we should be good now. Thanks!

Comment 15

[Germán Toro del Valle (:gtorodelvalle)]

Hi Kevin, thank you very much for your patch. The point is that there was some misunderstanding and my patch end up merged in master prematurely so I guess we have 2 options now:
  1) We could revert https://github.com/mozilla-b2g/gaia/commit/af96c97399b22de754fce06d152fd5b42b262920 (the commit with the updates already in master) and merge your pull request and its 2 commits.
  2) You could update your pull request (https://github.com/mozilla-b2g/gaia/pull/13675) removing the first commit (https://github.com/KevinGrandon/gaia/commit/5be5af7c7706225ecd6e445e22a0351128db5bc8) and leaving only the updates to the Marionette test cases.
Do you think option 2 is feasible? :-)

Comment 16

[Germán Toro del Valle (:gtorodelvalle)]

Damn it! You already did it :-)

Comment 17

[Germán Toro del Valle (:gtorodelvalle)]

We have just found an additional issue which we would like to solve in this same patch. I'll mark Kevin's PR as obsolete ASA I have a solution. The solution will take his PR as the starting point.

Comment 18

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 831938 [details] [review]
Gaia patch - Contacts testing updates

I have just confirmed that this "additional" bug already exists in master and consequently has nothing to do with my patch or Kevin's (obviously since he just updates the Marionette test cases which currently pass) ;-)

We're ready to go from my side.

Comment 19

[Kevin Grandon :kgrandon]

(In reply to gtorodelvalle from comment #18)
> Comment on attachment 831938 [details] [review]
> Github pull request
> 
> I have just confirmed that this "additional" bug already exists in master
> and consequently has nothing to do with my patch or Kevin's (obviously since
> he just updates the Marionette test cases which currently pass) ;-)
> 
> We're ready to go from my side.

Sounds good to me. I will simply update the tests and land them to master - then you are free to update the contacts code and land separately.

Comment 20

[Kevin Grandon :kgrandon]

Oops - must have misread your comment. I'll land both now as we have green - and we can fix that bug in another patch!

Comment 21

[Germán Toro del Valle (:gtorodelvalle)]

Evolving the bug to RESOLVED once Kevin has merged the patches. Thank you very much, Kevin ;-)

Merged in master: https://github.com/mozilla-b2g/gaia/commit/8fc53ebc7231ac95c6be80d6c541fbbde3c49276

Comment 22

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 8fc53ebc7231ac95c6be80d6c541fbbde3c49276
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 23

[Germán Toro del Valle (:gtorodelvalle)]

OK, the problem was due to the inclusion of some changes in the Marionette tests in this patch. v1.2 does not include Marionette tests. So the solution would be to delete them and not include them in the patch to land in v1.2.

No need to say that I have just confirmed that the patch works fine in v1.2.

Anyhow, since there are sensitive issues/decisions going on here, I will ask for José Manuel's OK to this before landing it in v1.2. The proposed commit for v1.2 is https://github.com/gtorodelvalle/gaia/commit/ea038ac7a927b12f9a17efa0c0103088dcaa3bc6

Comment 24

[Jose Manuel Cantera]

I think it is ok to land what you are proposing

thanks!

Comment 25

[Germán Toro del Valle (:gtorodelvalle)]

Landed in v1.2: https://github.com/mozilla-b2g/gaia/commit/a79411040e1200d421f1f36d0cd6008baacd068f

Comment 26

[Roland Kunkel [:RolandK]]

Verified as fixed for latest 1.2 and 1.3 build. When user navigates to contacts > settings, tapping along the bottom will not result in returning the user to the contact page.

1.2 Environmental Variables:
Device: Buri v1.2 COM RIL
BuildID: 20131204004003
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/244e98241b2c
Gaia: c8f14ad3950d59ba13d7639eff02d080060bb3ce
Version: 26.0
RIL Version: 01.02.00.019.102
Firmware Version: V1.2_20131115

1.3 Environmental Variables
Device: Buri v1.3 Mozilla RIL
Build ID: 20131203040236
Gecko: http://hg.mozilla.org/mozilla-central/rev/8648aa476eef
Gaia: 31808a29cfcffa584b6a88b4f1e515387f485a1b
Platform Version: 28.0a1
Firmware Version: v1.2_20131115