Closed Bug 935325 Opened 6 years ago Closed 6 years ago
IScript Global Object Owner
yet another useless interface we can just merge into nsIDocShell
Comment on attachment 827757 [details] [diff] [review] merge nsIScriptGlobalObjectOwner into nsIDocShell update uuid of nsIDocShell
Attachment #827757 - Flags: review?(bugs) → review+
It is not clear to me why you changed the method name. I'd prefer keeping GetScriptGlobalObject, but don't care too much. GetScriptGlobal is fine too.
(In reply to Olli Pettay [:smaug] from comment #3) > It is not clear to me why you changed the method name. > I'd prefer keeping GetScriptGlobalObject, but don't care too much. > GetScriptGlobal is fine too. no good reason only historical one I started patch by just adding new method to docshell but not completely killing interface then I saw I could get rid of interface but at that point I'd renamed it to avoid name collisions. So I'll change it back.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.