935326 - [B2G][MMS] The user cannot play an AMR file from a Sent or Received MMS

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: AMR.txt

Description:
The user cannot play an AMR file. The music player app will open when the file is selected in a MMS but it will not play the app.

Repro Steps:
1)  Updated Buri to Build ID: 20131103004003
2)  Tap on the "Messages" icon.
3)  Tap on the "Compose New Message" icon.
4)  Attach an AMR file and send the MMS message to another Buri v 1.2.0 device.
5)  Open the received MMS message and tap on the received AMR file. 

Actual:
The music player app will open but will not play the AMR file.

Expected:
(Describe the behavior you expected to have observed)

Environmental Variables
Device: Buri v 1.2.0 Mozilla RIL
Build ID: 20131103004003
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/eec4da1b27eb
Gaia: cb981e2f47bc644b4d178d54378c3676c946facf
Platform Version: 26.0

Notes:
Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/7752/
See attached: logcat

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

This issue does not reproduce on Leo v 1.10 COM RIL

Device: Leo v 1.1.0 COM RIL
Build ID: 20131030041204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/41c15ddb7216
Gaia: 39b0203fa9809052c8c4d4332fef03bbaf0426fc
Platform Version: 18.1
RIL Version: 01.01.00.019.264 

The AMR file plays without issue.

Comment 2

[Dominic Kuo [:dkuo]]

Caused by bug 830040 and bug 878057.

Comment 3

[Dominic Kuo [:dkuo]]

Attachment: Handle the share button when the player is not launched by open activity

Jim,

This is a simple patch that moved the code of showing/hiding the share button into the case that the player is not launched by the open activity, it was caused by the new sharing button and the locked music features which I mentioned in comment 2, would you please review it? thanks.

Comment 5

[Preeti Raghunath(:Preeti)]

koi+ for regression from 1.1

Comment 6

[Sarah Parsons]

This issue started to occur on the Buri 1.2 Build ID: 20131023004005
 
Gaia   1ca623e7a79a9653b54a45ef7f8bb03b8d7100fc
SourceStamp bb33e2fe109c
BuildID 20131023004005
Version 26.0a2


Last working Buri 1.2 Build ID: 20131022004000

Gaia   00d5964eabf95a6a8a632420dfa36fc76dcbc9b7
SourceStamp 7453a764f9a9
BuildID 20131022004000
Version 26.0a2

Comment 7

[Jim Porter (:squib)]

Comment on attachment 827947 [details] [review]
Handle the share button when the player is not launched by open activity

Looking at the code, this seems reasonable, so r=me.

Just to be sure: was the issue that, prior to this patch, we were trying to handle the share button in the open activity, but the open activity doesn't have a share button?

Comment 8

[Dominic Kuo [:dkuo]]

(In reply to Jim Porter (:squib) from comment #7)
> Comment on attachment 827947 [details] [review]
> Handle the share button when the player is not launched by open activity
> 
> Looking at the code, this seems reasonable, so r=me.
> 
> Just to be sure: was the issue that, prior to this patch, we were trying to
> handle the share button in the open activity, but the open activity doesn't
> have a share button?

Yes, in the v1.2 branch, because the open activity is using another page(open.html) to open the requested files, and the share button is not in that html, so when the open activity try to show/hide the share button, the variable will be undefined and causes error. In the master branch the error will be the "pendingPick" variable because it was declared in music.js, and the handling logic is in Player.js. And the patch just moved the code into the block that handles all conditions, except the open activity.

Comment 9

[Dominic Kuo [:dkuo]]

master: f7dc472a147d98e1eb6b39ceb9dc64448607424e
v1.2: 4cf40fb30c7b8380ea83ed0d4efe043b8b81737f