[Permission] video&Mic icon for prompt window

RESOLVED FIXED

Status

Firefox OS
Gaia::System
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gasolin, Assigned: gasolin)

Tracking

(Blocks: 1 bug)

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:-)

Details

(Whiteboard: [mentor=gasolin][mentor-lang=zh])

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
Currently we use video icon to present video&Mic use case

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/style/permission_manager/images/PermissionsDialogIcons_VideoRecorder.png

May need a separate icon to present video&Mic that similar to bug 917367
(Assignee)

Updated

4 years ago
blocking-b2g: --- → 1.3?
Depends on: 917367
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM

Updated

4 years ago
Blocks: 918876
(Assignee)

Updated

4 years ago
Whiteboard: [good first bug][mentor=gasolin][mentor-lang=zh]
blocking-b2g: 1.3? → -
(Assignee)

Updated

4 years ago
Whiteboard: [good first bug][mentor=gasolin][mentor-lang=zh] → [mentor=gasolin][mentor-lang=zh]
(Assignee)

Comment 1

4 years ago
ni? UX to provide a image
Flags: needinfo?(firefoxos-ux-bugzilla)
(In reply to Fred Lin [:gasolin] from comment #1)
> ni? UX to provide a image

The icons for this are already in the dupe here - https://bugzilla.mozilla.org/attachment.cgi?id=827432.
Flags: needinfo?(firefoxos-ux-bugzilla)
(In reply to Jason Smith [:jsmith] from comment #2)
> (In reply to Fred Lin [:gasolin] from comment #1)
> > ni? UX to provide a image
> 
> The icons for this are already in the dupe here -
> https://bugzilla.mozilla.org/attachment.cgi?id=827432.

I mean not dupe - but the original bug where we worked on the notification icons.
(Assignee)

Comment 4

4 years ago
The attachment provides `red` background icons, I think it's too strong and not follow the styles of permission dialogs icons. How do you think?
(In reply to Fred Lin [:gasolin] from comment #4)
> The attachment provides `red` background icons, I think it's too strong and
> not follow the styles of permission dialogs icons. How do you think?

Red was originally chosen to my understanding because the red color is a universal indicator of recording & matches the recording indicator (which is a red dot). The color strength is fine to be different here in the permission dialog vs. notifications because in the permission dialog, you are requesting access to your mic/camera instead of having recording active - that implies no red color in the icon. The notification indicator on the other hand is showing that recording is active, which adds a red color to match the universal indicator for recording.
(Assignee)

Comment 6

4 years ago
Yes, in this issue we'd like to replace the `permission dialog icon` but not the status indicator icon.
The attachment mentioned above only contains icons for status indicator.
So we still need a new permission dialog icon (blue, no background) for this case.
(In reply to Fred Lin [:gasolin] from comment #6)
> Yes, in this issue we'd like to replace the `permission dialog icon` but not
> the status indicator icon.
> The attachment mentioned above only contains icons for status indicator.
> So we still need a new permission dialog icon (blue, no background) for this
> case.

Oh. Right. Misread the bug. Yeah, we need image icon resources for this.
Flags: needinfo?(firefoxos-ux-bugzilla)

Comment 8

4 years ago
Flagging Peter for image icon and any necessary reassignment here.
Flags: needinfo?(firefoxos-ux-bugzilla) → needinfo?(pla)

Comment 9

4 years ago
Created attachment 8377729 [details]
Icons for Video&Mic + Video Only in 3 resolutions (@1, @1.5, @2)

Attached is an icon for Video & Microphone permissions, as well as a slightly revised Video permissions icon @1, @1.5, and @2 x resolution.

Source file:
https://mozilla.box.com/s/rtopo2zp5usuomerkc7h
Flags: needinfo?(pla)
(Assignee)

Comment 10

4 years ago
Thanks peter!
Assignee: nobody → gasolin
(Assignee)

Comment 11

4 years ago
Created attachment 8377975 [details] [review]
pull request redirect to github

resource only change
Attachment #8377975 - Flags: review?(alive)
Attachment #8377975 - Flags: review?(alive) → review+
(Assignee)

Comment 12

4 years ago
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/99b4f7aa20c3c1774976a0c25025eafeea272a76

thanks!
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
The PNG images that were landed as part of this bug were not properly compressed, please do so in a follow up using the script provided in the gaia tools directory (you will need the optipng and advancecomp packages installed):

./tools/png_recompress.sh -v \
  apps/system/style/permission_manager/images/PermissionsDialogIcons_VideoAndMic.png \
  apps/system/style/permission_manager/images/PermissionsDialogIcons_VideoAndMic@1.5x.png \
  apps/system/style/permission_manager/images/PermissionsDialogIcons_VideoAndMic@2x.png \
  apps/system/style/permission_manager/images/PermissionsDialogIcons_VideoRecorder.png \
  apps/system/style/permission_manager/images/PermissionsDialogIcons_VideoRecorder@1.5x.png \
  apps/system/style/permission_manager/images/PermissionsDialogIcons_VideoRecorder@2x.png

Doing so yields a 99.5% (!) reduction in size which has a very measurable impact on ZIP file size and memory footprint.
(Assignee)

Updated

4 years ago
Blocks: 975350
(Assignee)

Comment 14

4 years ago
Thanks for remind, followup bug added.
You need to log in before you can comment on or make changes to this bug.