935342 - [Permission] video&Mic icon for prompt window

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[[e-mail]]

Currently we use video icon to present video&Mic use case

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/style/permission_manager/images/PermissionsDialogIcons_VideoRecorder.png

May need a separate icon to present video&Mic that similar to bug 917367

Comment 1

[[e-mail]]

ni? UX to provide a image

Comment 2

[Jason Smith [:jsmith]]

(In reply to Fred Lin [:gasolin] from comment #1)
> ni? UX to provide a image

The icons for this are already in the dupe here - https://bugzilla.mozilla.org/attachment.cgi?id=827432.

Comment 3

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #2)
> (In reply to Fred Lin [:gasolin] from comment #1)
> > ni? UX to provide a image
> 
> The icons for this are already in the dupe here -
> https://bugzilla.mozilla.org/attachment.cgi?id=827432.

I mean not dupe - but the original bug where we worked on the notification icons.

Comment 4

[[e-mail]]

The attachment provides `red` background icons, I think it's too strong and not follow the styles of permission dialogs icons. How do you think?

Comment 5

[Jason Smith [:jsmith]]

(In reply to Fred Lin [:gasolin] from comment #4)
> The attachment provides `red` background icons, I think it's too strong and
> not follow the styles of permission dialogs icons. How do you think?

Red was originally chosen to my understanding because the red color is a universal indicator of recording & matches the recording indicator (which is a red dot). The color strength is fine to be different here in the permission dialog vs. notifications because in the permission dialog, you are requesting access to your mic/camera instead of having recording active - that implies no red color in the icon. The notification indicator on the other hand is showing that recording is active, which adds a red color to match the universal indicator for recording.

Comment 6

[[e-mail]]

Yes, in this issue we'd like to replace the `permission dialog icon` but not the status indicator icon.
The attachment mentioned above only contains icons for status indicator.
So we still need a new permission dialog icon (blue, no background) for this case.

Comment 7

[Jason Smith [:jsmith]]

(In reply to Fred Lin [:gasolin] from comment #6)
> Yes, in this issue we'd like to replace the `permission dialog icon` but not
> the status indicator icon.
> The attachment mentioned above only contains icons for status indicator.
> So we still need a new permission dialog icon (blue, no background) for this
> case.

Oh. Right. Misread the bug. Yeah, we need image icon resources for this.

Comment 8

[Stephany Wilkes]

Flagging Peter for image icon and any necessary reassignment here.

Comment 9

[Peter La]

Attachment: Icons for Video&Mic + Video Only in 3 resolutions (@1, @1.5, @2)

Attached is an icon for Video & Microphone permissions, as well as a slightly revised Video permissions icon @1, @1.5, and @2 x resolution.

Source file:
https://mozilla.box.com/s/rtopo2zp5usuomerkc7h

Comment 10

[[e-mail]]

Thanks peter!

Comment 11

[[e-mail]]

Attachment: pull request redirect to github

resource only change

Comment 12

[[e-mail]]

merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/99b4f7aa20c3c1774976a0c25025eafeea272a76

thanks!

Comment 13

[Gabriele Svelto [:gsvelto]]

The PNG images that were landed as part of this bug were not properly compressed, please do so in a follow up using the script provided in the gaia tools directory (you will need the optipng and advancecomp packages installed):

./tools/png_recompress.sh -v \
  apps/system/style/permission_manager/images/PermissionsDialogIcons_VideoAndMic.png \
  apps/system/style/permission_manager/images/[e-mail] \
  apps/system/style/permission_manager/images/[e-mail] \
  apps/system/style/permission_manager/images/PermissionsDialogIcons_VideoRecorder.png \
  apps/system/style/permission_manager/images/[e-mail] \
  apps/system/style/permission_manager/images/[e-mail]

Doing so yields a 99.5% (!) reduction in size which has a very measurable impact on ZIP file size and memory footprint.

Comment 14

[[e-mail]]

Thanks for remind, followup bug added.