Closed Bug 935375 Opened 6 years ago Closed 6 years ago

Word offsets broken if the next word is an embedded object

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla29
Tracking Flags:
Tracking Status
firefox28 --- fixed
firefox29 --- fixed

People

(Reporter: Jamie, Assigned: surkov)

References

(Blocks 1 open bug)

Details

(Keywords: regression, Whiteboard: [qa-])

Attachments

(2 files)

patch
14.32 KB, patch
tbsaunde
: review+
Details | Diff | Splinter Review
aurora patch
5.26 KB, patch
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Str:
1. Use the following code:
<body>
a <a href="#">b</a>
</body>
2. Get the offsets for the word at offset 0; e.g. via IAccessibleText::textAtOffset with IA2_TEXT_BOUNDARY_WORD.
Expected: (0, 2)
Actual: (2, 2)
Same for offset 1.

Impact: Among other things, brokenness for screen reader users when using control+backspace in these situations.

Symptom originally reported by an NVDA user here: http://community.nvda-project.org/ticket/3621
Blocks: getText*a11y
I get (0, 2) on Nightly. Jamie, can you retest it please and if it doesn't work then provide a test case (simple "data:text/html,a <a href="www">b</a>" works as expected for me)
Wow! I didn't know about data: URLs. You learn something new every day. :)

Just tested with latest nightly and I get the same result using an html file. I even pasted:
data:text/html,a <a href="www">b</a>
into the Address bar and tested with that. I get the same result.
To clarify (since i wasn't clear in my str), I'm doing this on the document accessible.
you're right, I just figured out I tested wrong version. I can reproduce a problem now

(In reply to James Teh [:Jamie] from comment #2)
> Wow! I didn't know about data: URLs. You learn something new every day. :)

yep, it's a nice feature, I just get used to forget it syntax occasionally :)
Attached patch patch — — Splinter Review
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #8341692 - Flags: review?(trev.saunders)
Attachment #8341692 - Flags: review?(trev.saunders) → review+
https://hg.mozilla.org/mozilla-central/rev/aa29a685d835
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Keywords: regression
Attached patch aurora patch — — Splinter Review 
[Approval Request Comment]
Bug caused by (feature/regressing bug #): something from recent text works, bug getText*a11y
User impact if declined: text navigation problem in firefox/thunderbird for AT users
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): small risk (should be ok for early cycle)
String or IDL/UUID changes made by this patch: no
Attachment #8349050 - Flags: approval-mozilla-aurora?
Attachment #8349050 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Keywords: checkin-needed
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.