935379 - RemoteWebProgress should handle missing progress methods and exceptions in existing methods.

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Some tests (eg, browser_keywordSearch.js) add a web progress listener but only implement one of the methods defined in this interface.  RemoteWebProgress.jsm then gets upset.  Things will also get upset if one of the listeners fails - other listeners will fail to be called.

I'll attach a patch to handle both these cases.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Add a _delegateToListeners() helper which both handles missing methods and catches and reports exceptions

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 827824 [details] [diff] [review]
Add a _delegateToListeners() helper which both handles missing methods and catches and reports exceptions

To stay consistent with tabbrowser that does a very similar thing, let's call the function _callProgressListeners

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Thanks!  Landed with comments addressed.

https://hg.mozilla.org/integration/fx-team/rev/393e70ad5cd9

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/393e70ad5cd9