Closed
Bug 935379
Opened 12 years ago
Closed 12 years ago
RemoteWebProgress should handle missing progress methods and exceptions in existing methods.
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: markh, Assigned: markh)
References
(Blocks 1 open bug)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
Some tests (eg, browser_keywordSearch.js) add a web progress listener but only implement one of the methods defined in this interface. RemoteWebProgress.jsm then gets upset. Things will also get upset if one of the listeners fails - other listeners will fail to be called.
I'll attach a patch to handle both these cases.
Assignee | ||
Comment 1•12 years ago
|
||
Assignee: nobody → mhammond
Attachment #827824 -
Flags: review?(felipc)
Comment 2•12 years ago
|
||
Comment on attachment 827824 [details] [diff] [review]
Add a _delegateToListeners() helper which both handles missing methods and catches and reports exceptions
To stay consistent with tabbrowser that does a very similar thing, let's call the function _callProgressListeners
Attachment #827824 -
Flags: review?(felipc) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Thanks! Landed with comments addressed.
https://hg.mozilla.org/integration/fx-team/rev/393e70ad5cd9
Status: NEW → ASSIGNED
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•