Closed Bug 935379 Opened 6 years ago Closed 6 years ago
Web Progress should handle missing progress methods and exceptions in existing methods .
Some tests (eg, browser_keywordSearch.js) add a web progress listener but only implement one of the methods defined in this interface. RemoteWebProgress.jsm then gets upset. Things will also get upset if one of the listeners fails - other listeners will fail to be called. I'll attach a patch to handle both these cases.
Assignee: nobody → mhammond
Attachment #827824 - Flags: review?(felipc)
Comment on attachment 827824 [details] [diff] [review] Add a _delegateToListeners() helper which both handles missing methods and catches and reports exceptions To stay consistent with tabbrowser that does a very similar thing, let's call the function _callProgressListeners
Attachment #827824 - Flags: review?(felipc) → review+
Thanks! Landed with comments addressed. https://hg.mozilla.org/integration/fx-team/rev/393e70ad5cd9
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.