935433 - Merge test_clock_all_items_present_new_alarm assertions into existing tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Zac C (:zac)]

This is a task to move the assertions in
test_clock_all_items_present_new_alarm.py

into the respective other tests, for example:
alarm_label assertion move into > test_clock_create_new_alarm.py
alarm_repeat assertion move into > test_clock_set_alarm_repeat.py

Finally, remove test_clock_all_items_present_new_alarm.py from the repository and the manifest files.

Comment 1

[[:AndreiH]]

Attachment: PR https://github.com/mozilla-b2g/gaia/pull/13428

Comment 2

[Trif Andrei-Alin[:AlinT]]

Comment on attachment 827994 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/13428

just a small fix, and the pull is good to go

Comment 3

[Zac C (:zac)]

Comment on attachment 827994 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/13428

AlinT's r- was addressed. R+ from me!

Comment 4

[Zac C (:zac)]

Merged on master:

https://github.com/mozilla-b2g/gaia/commit/591d22e7495c48fb45b29e05592f25054d2a1f5a

This should be a useful and painless merge to v1.2

Comment 5

[Bob Silverberg [:bsilverberg]]

Adding a whiteboard entry to mark this as needing attention for v1.2.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

John, can you please help with the uplift to v1.2? :)

Comment 7

[Bob Silverberg [:bsilverberg]]

We;re going to do this uplift manually too, thanks anyway RyamVM and jhford. :)

Comment 8

[[:AndreiH]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/13506

Comment 9

[Bob Silverberg [:bsilverberg]]

Landed in v1.2: https://github.com/mozilla-b2g/gaia/commit/584e25aff164873b5fb0e5f86e3d0383e7e0a1b0