935442 - [System] 1 unit tests failure with the latest firefox builds

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Julien Wajsberg [:julienw]]

I took the Linux build from ftp://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-linux64/1383714839/

This one comes from this tbpl build: https://tbpl.mozilla.org/?rev=9ba3faa35c96
This is not the first failing build.

Running the syste! unit tests when running the test-agent inside that Firefox build get me these issues:

  1) [system] ActionMenu "before all" hook:
     TypeError: setting a property that has only a getter
      at (anonymous) (http://system.gaiamobile.org:8080/test/unit/action_menu_test.js:46)

Comment 1

[Julien Wajsberg [:julienw]]

This comes from the use of a global "screen" variable in the test. Unfortunately, such property exists in Window, see [1], and probably it was changed recently.

[1] https://developer.mozilla.org/en-US/docs/Web/API/Window.screen

Comment 2

[Julien Wajsberg [:julienw]]

Attachment: github PR

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 827966 [details] [review]
github PR

I prefer to have screenElement instead of |screen| variable.

Comment 4

[Julien Wajsberg [:julienw]]

bug 932322 triggered this.

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed in:
https://github.com/mozilla-b2g/gaia/commit/c9dc3cb8b01d3d3118a2c9e5ada531799444c297

Comment 6

[Peter Van der Beken [:peterv]]

screen is a normal readonly property on a global object, so it's on the window object and not settable.

Comment 7

[Julien Wajsberg [:julienw]]

Yep, the unit test was badly written.