935495 - [first run] don't use word suggestion/spell check/autocorrection for password input to connect to hidden Wi-Fi network

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Boot2Gecko 1.2.0.0-prerelease 20131104224010 on Keon, update channel 'default'

Similar to bug 825061.

When connecting to a hidden Wi-Fi network with WPA-PSK, the password input gets spellchecked.

Comment 1

[Kevin Grandon :kgrandon]

Seems this was fixed at some point.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Reopening. After resetting my Keon (Boot2Gecko 2.2.0.0-prerelease 20141009012329) and trying to join a hidden network in the FTU, autocorrection changes the input in the password field.

Comment 3

[Sam Foster [:sfoster] (he/him)]

We should fix this. Can we check 2.1? Seems like a potential blocker if it is affected.

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Also happens with 2.1.0.0 20141009000203 on Flame KK.

Comment 5

[Sam Foster [:sfoster] (he/him)]

Apologies for the fire-drill, I was in the middle or something and not able to check on what sounded like a potentially serious issue. Having looked at this, this is a bit annoying only: the suggestions arent applicable when entering a password. Nothing is actually replaced from under the user, you just keep typing and ignore the suggestions.

The input in question toggles between 'text' and 'password' type based on the 'show password' checkbox. When its a password type, you get no suggestions. When its a text type, you do. We need to provide a hint to the keyboard app to not show this stuff, but my initial naive efforts using autocomplete="off" did nothing. I'll keep an eye out and ask around for how to accomplish this. Putting it on the backlog meantime.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

> Nothing is actually replaced from under the user, you just keep typing and ignore the suggestions.
Looking at the bug summary, I might have expressed the issue not clearly enough: While showing the password and typing, if autocorrection is enabled, the input will get autocorrected.

Steps to reproduce:
1. Enable autocorrection (is enabled by default in production builds on some devices).
2. Set language to English (US) and also use the English keyboard.
3. Go to Settings > Wi-Fi > Manage Networks > Join Hidden Network.
4. Toggle the checkbox to show the password
4. In the password field, type "hairi mo "
Actual result:
Password field contains "Haiti mob "

Expected result:
Password field contains "hairi mo "

Comment 7

[Sam Foster [:sfoster] (he/him)]

Ok noted, I'm adding systemsfe for consideration as a blocker

Comment 8

[Sam Foster [:sfoster] (he/him)]

[Blocking Requested - why for this release]: Bad UX, password gets autocorrected when trying to connect to hidden network

Comment 9

[Kevin Grandon :kgrandon]

Being that this has been there for 1 year+, it seems unlikely that we'd block on this for the last day of FC. Something we should definitely fix though. Maybe we can request uplift on it?

Comment 10

[Gregor Wagner [:gwagner]]

I agree with Kevin. Definitely priority to fix but its not a blocker. Lets go the uplift approval way and decide based on the risk.

Comment 11

[Sam Foster [:sfoster] (he/him)]

Ah ha. From  the #wifi_password field in the same file (apps/ftu/index.html) it seems we need x-inputmode="verbatim" on #hidden-wifi-password

Comment 12

[Sam Foster [:sfoster] (he/him)]

Working on this + marionette test

Comment 13

[Sam Foster [:sfoster] (he/him)]

Attachment: Add x-inputmode=verbatim to avoid autocorrecting password

Adds a-inputmode="verbatim" on the hidden network password field as our current/only mechanism to disable autocorrect in a text field. 

In the marionette test, I tried testing the actual autocorrect behavior with sendKeys and waits in the test, but although you can watch the keyboard show and the suggestions list populate, we dont get the same autocorrecting behavior as on device. So the test just asserts that x-inputmode has value verbatim for now.

Note that bug 1084186 tracks the issue that x-inputmode=verbatim is really a workaround for turning off autocorrect. If we get other options from the platform, we'll want to revisit this.

Comment 14

[Fernando Campo (:fcampo)]

Comment on attachment 8507215 [details] [review]
Add x-inputmode=verbatim to avoid autocorrecting password

Although I wasn't able to repro on current master (so it might have been fixed at some point), adding verbatim to inputmode it's the way it should be, so glad we're adding it.

Just added a comment for a minor style nit, thanks Sam.

Comment 15

[Sam Foster [:sfoster] (he/him)]

Merged to master: https://github.com/mozilla-b2g/gaia/commit/ac73ec022b29b835c4a27d13d08c32acedf8c57d
Commit: https://github.com/mozilla-b2g/gaia/commit/e14b283312eb81305afcae5020971963329b79da

:fcampo: I got the wifi_test change in there you noted to keep the HTML the same. I'd rather do any batch id convention renaming in a separate bug. That particular one I touched because it duplicated another element with the same id, and produced initially-puzzling results when I was trying to write a marionette test for it

Comment 16

[Fernando Campo (:fcampo)]

(In reply to Sam Foster [:sfoster] from comment #15)
> :fcampo: I got the wifi_test change in there you noted to keep the HTML the
> same. 
Thanks :)
> I'd rather do any batch id convention renaming in a separate bug. 
+1