935557 - [Buri][Geolocation] Geolocation prompt missing text

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Marcia Knous [:marcia]]

Attachment: Screenshot of issue during testing

Buri, while using 11-4 Base image and:

Gaia   3b5fe429f2414f2a9d7241b311b399033bb10612
SourceStamp 9ba3faa35c96
BuildID 20131106040203
Version 28.0a1

STR:
1. Launch the camera app and wait for the Geolocation prompt
2. Observe attached screenshot

Comment 1

[Jason Smith [:jsmith]]

Weird. That's a different test result than what's seen in bug 935427 - that bug indicates the prompt isn't appearing at all.

Comment 3

[Montoya Clemmons (MClemmons)]

This issue reproduces on Buri 1.3 Build 20131106040203

Last working build ( Does not Reproduce) Buri 1.3 BuildID: 20131104044747
Environmental Variables:
Device: Buri v1.3 Mozilla RIL
BuildID: 20131104044747
Gaia: 1aee772a384f1ed1148f08c6c7df45d2fe35506e
Gecko: b4143e04bea1
Version: 28.0a1

First Broken (Reproduces) 
Environmental Variables:
Device: Buri v1.3 Mozilla RIL
BuildID: 20131106040203
Gaia: 3b5fe429f2414f2a9d7241b311b399033bb10612
Gecko: 9ba3faa35c96
Version: 28.0a1


This issue does not reproduce on Buri 1.2 Build ID 20131106004004 (attempted 5 times) 

Environmental Variables:
Device: Buri v1.2 Mozilla RIL
BuildID: 20131106004004
Gaia: 2140c987fdde1c99097018f7e93b0bbd43d2125d
Gecko: 6a831fcb96f4
Version: 26.0

Could not reproduce on 11/5 Buri 1.3 Build ID 20131105040208 as user is not prompted with any Geolocation text

Comment 4

[Jason Smith [:jsmith]]

Fred - Alive thinks this regressed from the recent gUM work. Can you take a look?

Comment 5

[[e-mail]]

I think its related to gecko backout the bug 853356, so the paired gaia patch can't get proper permission name from gecko.

We could wait bug 853356 land again, or backout the paired patch (bug 919927)

cc alfredo for gecko patch status

Comment 6

[Jason Smith [:jsmith]]

(In reply to Fred Lin [:gasolin] from comment #5)
> I think its related to gecko backout the bug 853356, so the paired gaia
> patch can't get proper permission name from gecko.
> 
> We could wait bug 853356 land again, or backout the paired patch (bug 919927)
> 
> cc alfredo for gecko patch status

We should backout the paired gaia patch in that case, as this is a smoketest regression.

Comment 7

[Jason Smith [:jsmith]]

Fixed by backing out in https://bugzilla.mozilla.org/show_bug.cgi?id=919927#c9.

Comment 8

[Jason Smith [:jsmith]]

Backout failed.

Comment 9

[[e-mail]]

Attachment: pull request redirect to github

add compatibility code that passed the origin permission string in prompt, so all permissions(except gUM) works as usual, and no need to backout gaia code

Comment 10

[Zac C (:zac)]

Comment on attachment 829036 [details] [review]
pull request redirect to github

One more thing is that you need to enable the test_geolocation_prompt.py file by removing "expected = fail" from the test's tag in tests/system/manifest.ini and re-committing the change.

You can see in the Travis results it says "unexpected success" which is a good thing, it means your patch has worked :)

After changing the manifest it will just be "pass"

Comment 11

[[e-mail]]

Zac, Thanks for feedback, removed the test's tag in tests/system/manifest.ini

Comment 12

[Jason Smith [:jsmith]]

(In reply to Fred Lin [:gasolin] from comment #9)
> Created attachment 829036 [details] [review]
> pull request redirect to github
> 
> add compatibility code that passed the origin permission string in prompt,
> so all permissions(except gUM) works as usual, and no need to backout gaia
> code

This is a smoketest regression - we should always backout first, then reland with the necessary fix.

Comment 13

[Kevin Grandon :kgrandon]

(In reply to Fred Lin [:gasolin] from comment #11)
> Zac, Thanks for feedback, removed the test's tag in tests/system/manifest.ini

Just noting that in bug 919927 I re-enabled the test due to the unexpected success after backout. I left the tag and comments in there though in case we need to mark the test as failed again after patches re-land.

Comment 14

[Jason Smith [:jsmith]]

Fixed by backout in https://bugzilla.mozilla.org/show_bug.cgi?id=919927#c12.

Comment 15

[Jason Smith [:jsmith]]

Blocking+ for smoketest regression