Closed Bug 935572 Opened 6 years ago Closed 6 years ago

remove nsIAccessibleHyperLink::selected

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 1 open bug)

Details

(Keywords: access, Whiteboard: [qa-])

Attachments

(1 file)

Attached patch patchSplinter Review
that was used for atk-hyperlink-is-selected-link

https://developer.gnome.org/atk/unstable/AtkHyperlink.html#atk-hyperlink-is-selected-link

which is deprectated and not implemented by Firefox.

The link suggest to use ATK_STATE_SELECTED which is wrong (per irc char with Joanie):

alexsurkov: joanie: do you rely on ATK_STATE_SELECTED on links? https://developer.gnome.org/atk/unstable/AtkHyperlink.html#atk-hyperlink-is-selected-link
[10:42am] joanie: alexsurkov: nope
[10:42am] joanie: in fact, that would be wrong
[10:42am] joanie: links are focused

so just remove all related code
Attachment #828094 - Flags: review?(trev.saunders)
Attachment #828094 - Flags: review?(trev.saunders) → review+
https://hg.mozilla.org/mozilla-central/rev/cfb113ac2db3
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.