Closed Bug 935573 Opened 6 years ago Closed 6 years ago

[bluedroid] Add Connect/Disconnect api

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: shawnjohnjr, Assigned: ben.tian)

References

Details

Attachments

(1 file, 4 obsolete files)

[bluedroid] Add Connect/Disconnect api
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
Assignee: shuang → btian
Changes:
- implement Connect() and Disconnect() in BluetoothServiceBluedroid.cpp. Both functions fire error reply directly as profile managers are not ready now.
- add get/set bluetooth interface function into BluetoothUtils, and move StringToBdAddressType() to BluetoothUtils for profile managers' use.
- add some macro utilities.

TODO: Remove error reply in Connect() and Disconnect() once profile managers are revised.
Attachment #829145 - Flags: review?(echou)
Comment on attachment 829145 [details] [diff] [review]
Patch 1 (v1): connect/disconnect api

The BluetoothUtils changes are incompatible with BlueZ. I'll remove these changes and upload revised patch.
Attachment #829145 - Attachment is obsolete: true
Attachment #829145 - Flags: review?(echou)
Changes:
- add connect/disconnect api. Reply error for now and remove it once profile managers are done.
- add macro to declare profile manager base functions
Attachment #829979 - Flags: review?(echou)
Add missing declaration.
Attachment #829979 - Attachment is obsolete: true
Attachment #829979 - Flags: review?(echou)
Attachment #830006 - Flags: review?(echou)
Comment on attachment 830006 [details] [diff] [review]
Patch 1 (v2): add Connect/Disconnect api

Review of attachment 830006 [details] [diff] [review]:
-----------------------------------------------------------------

ok, overall looks good, although I have concerns about doing function call after 'return'. Could you slightly modify the logic to avoid compile warnings before checking in?
Attachment #830006 - Flags: review?(echou) → review+
Revise to avoid warning.
Attachment #830006 - Attachment is obsolete: true
Depends on: 937199
Rebased patch to avoid dependency of bug 921991.
Attachment #830018 - Attachment is obsolete: true
No longer depends on: 921991
Request to check in the rebased patch (comment 10) since bug 937199 crash only relates to bug 921991's change (BluetoothRilListener). Also I've verified nexus-4 startup on debug build w/ the rebased patch.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ca28979428ed
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.