935612 - We should stop using TreatUndefinedAs in PhoneNumberService.webidl

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Boris Zbarsky [:bzbarsky]]

WebIDL is likely going to drop TreatUndefinedAs entirely; in our tree this API is the sole consumer at this point, once the bogosity of bug 929435 is sorted out.

Now that bug 829248 is fixed, I believe this API can simply be rewritten as:

 DOMRequest fuzzyMatch([TreatNullAs=EmptyString] optional DOMString number1 = "",
                       [TreatNullAs=EmptyString] optional DOMString number2 = "");

right?

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

If I understand correctly that undefined/missing parameters to fuzzyMatch will take the default value of an empty string, then yes this would be a good change.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Yes.  The one difference from what we have today is that this:

  fuzzyMatch();

would just act like fuzzyMatch("", "") instead of throwing an exception.  Is that OK?

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

I don't see a problem with that.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Stop using TreatUndefinedAs in PhoneNumberService.

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 829485 [details] [diff] [review]
Stop using TreatUndefinedAs in PhoneNumberService.

Review of attachment 829485 [details] [diff] [review]:
-----------------------------------------------------------------

Mochitests (chrome/plain) still green for desktop, integration tests still green for B2G. LGTM.

Comment 6

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f605430674e2

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/f605430674e2