935708 - save-bookmark.js fails

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Eitan Isaacson [:eeejay]]

[homescreen] save-bookmark.js >
    ✓ [homescreen] Homescreen is listening right now  
    ✓ [homescreen] The new bookmark has been added correctly  (720ms)
    ✓ [homescreen] Bookmarking failed - request cancelled by user  
    ✓ [homescreen] Bookmarking failed - error name not supported  
    ✓ [homescreen] Bookmarking failed - error type not supported  
    1) [homescreen] The status is displayed when a bookmark has been added correctly 


  ✖ 1 of 6 tests failed:

  1) [homescreen] save-bookmark.js > The status is displayed when a bookmark has been added correctly :
     Error: TypeError: document.querySelectorAll(...).textContent is undefined (http://homescreen.gaiamobile.org:8080/test/unit/save_bookmark_test.js?time=1383772348532:107)
      at onerror (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4959)

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13441

Pointer to Github pull-request

Comment 2

[Cristian Rodriguez (:crdlc)]

Comment on attachment 828247 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13441

Thanks a lot, good catch, I fixed this for v1.2 but not for master :(

https://github.com/mozilla-b2g/gaia/blob/v1.2/apps/homescreen/test/unit/save_bookmark_test.js#L107

Comment 3

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/ac344aa6c6e9920e55b4899bf77518625bd9c35b