Status

Input Graveyard
Code Quality
P3
normal
RESOLVED FIXED
4 years ago
11 months ago

People

(Reporter: willkg, Assigned: willkg)

Tracking

Details

(Whiteboard: u=dev c=codequality p=1 s=input.2014q3)

We use homebrew model makers in the test code and some other places. This works, but in some cases it's clunky.

Seems a lot easier to switch to FactoryBoy for model makers. Syntax is nice. Looks easy to deal with. Should be straight-forward to switch.

http://factoryboy.readthedocs.org/en/latest/
Pushing this off to 2014q1 because I can't get to it this quarter.
Whiteboard: u=dev c=codequality p= s=input.2013q4 → u=dev c=codequality p= s=input.2014q1
Moving this to 2014q2.
Whiteboard: u=dev c=codequality p= s=input.2014q1 → u=dev c=codequality p= s=input.2014q2
Bumping this to 2014q3 when I plan to do a round of updates of things.
Whiteboard: u=dev c=codequality p= s=input.2014q2 → u=dev c=codequality p= s=input.2014q3
Added it to vendor/ in https://github.com/mozilla/fjord/commit/0d8e024

This bug should cover ditching our model makers and switching to it, too. So leaving it open.
This switches all the tests to use FactoryBoy factories: https://github.com/mozilla/fjord/commit/7c7009b

Since this is all test-related, it doesn't need to go to production, so I'm going to mark it FIXED now.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
This was about 1 point. I did part of it this afternoon and the rest this evening.
Assignee: nobody → willkg
Whiteboard: u=dev c=codequality p= s=input.2014q3 → u=dev c=codequality p=1 s=input.2014q3
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.