Closed Bug 935739 Opened 8 years ago Closed 7 years ago

XUL styling ignores "font-variant: small-caps"

Categories

(Core :: XUL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: cbaker, Assigned: jfkthame)

References

Details

(Keywords: fonts)

Attachments

(2 files)

Attached file styleproblem.xul
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20100101 Firefox/25.0 (Beta/Release)
Build ID: 20131025151332

Steps to reproduce:

Try to style a XUL label:

<label value="This line should be styled in small-caps." style="font-variant: small-caps;"/>


Actual results:

The label is not styled in small-caps.  In fact, it is styled in such a fashion that it is indistinguishable from a non-styled label.


Expected results:

The label should be styled in small-caps.
Keywords: fonts
Status: UNCONFIRMED → NEW
Component: Untriaged → XUL
Ever confirmed: true
OS: Windows 7 → All
Product: Firefox → Core
Hardware: x86_64 → All
Version: 25 Branch → Trunk
If we move the implementation of small-caps from layout (nsTextFrame.cpp and nsTextRunTransformations.cpp) over into gfx, making it an attribute of gfxFontStyle that is implemented at rendering time, this becomes trivial.

I have an experimental patch for this refactoring. I'll file a separate bug for that, and tidy up the patch for review; then we can make this dependent on it.

(See also bug 1011187 re HTML Canvas 2D text.)
Depends on: 1015603
This issue is fixed by bug 1015603; here's a reftest for it.
Attachment #8428718 - Flags: review?(roc)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Testcase:
https://hg.mozilla.org/integration/mozilla-inbound/rev/00b35aba6972
Target Milestone: --- → mozilla32
https://hg.mozilla.org/mozilla-central/rev/00b35aba6972
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.