935788 - Pretty Print button breaks attempting to work on non-js files

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Jeff Griffiths (:canuckistani) (:⚡︎)]

STR:

* look at a json file, eg taps.json from http://canuckistani.github.io/st-beer/
* hit the pretty print button, there's a log message 'togglePrettyPrint threw an exception: Can't prettify non-javascript files.', but the button stays activated
* only way to get it de-activated is toggle black box button on, then off

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: bug-935788-pp-non-js.patch

https://tbpl.mozilla.org/?tree=Try&rev=e3964c818177

Comment 2

[Victor Porof [:vporof][:vp]]

Comment on attachment 830505 [details] [diff] [review]
bug-935788-pp-non-js.patch

Review of attachment 830505 [details] [diff] [review]:
-----------------------------------------------------------------

Take my r+. TAKE IT!

::: browser/devtools/debugger/test/browser_dbg_pretty-print-12.js
@@ +19,5 @@
> +    gDebugger = gPanel.panelWin;
> +    gEditor = gDebugger.DebuggerView.editor;
> +    gSources = gDebugger.DebuggerView.Sources;
> +
> +    waitForSourceShown(gPanel, "")

You could use preferredValue here instead of this and the next then, but meh.

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

https://hg.mozilla.org/integration/fx-team/rev/77765853448f

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/77765853448f

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 830505 [details] [diff] [review]
bug-935788-pp-non-js.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #):

Bug 916180

User impact if declined: 

It will appear as if you can pretty print non-js files (such as html files) in the debugger, but then won't pretty print the file, but the UI will still act like the file is pretty printed.

Testing completed (on m-c, etc.):

Patch has been on m-c for a few days with no hiccups.

Risk to taking this patch (and alternatives if risky):

Very little. Tiny patch that affects a developer-only facing feature.

String or IDL/UUID changes made by this patch:

None.

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c0c46ae54ed7