Closed
Bug 935804
Opened 12 years ago
Closed 12 years ago
Get rid of [TreatUndefinedAs] in the Contacts API
Categories
(Core Graveyard :: DOM: Contacts, defect)
Core Graveyard
DOM: Contacts
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: reuben, Assigned: reuben)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
5.67 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
The patch in Bug 929435 is terribad. Here's a proper fix.
Attachment #828389 -
Flags: review?(bzbarsky)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 828389 [details] [diff] [review]
Receive nullable things in initialize() and use ise() instead of is() in the tests.
Making already-optional arguments also nullable is about null handling, not undefined handling, right?
r=me if so
Attachment #828389 -
Flags: review?(bzbarsky) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
Yep. Thanks for the review.
https://hg.mozilla.org/integration/b2g-inbound/rev/0526eb0b1f08
|
|
||
Comment 3•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
|
||
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•