Closed Bug 935804 Opened 11 years ago Closed 11 years ago

Get rid of [TreatUndefinedAs] in the Contacts API

Categories

(Core Graveyard :: DOM: Contacts, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla28

People

(Reporter: reuben, Assigned: reuben)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

The patch in Bug 929435 is terribad. Here's a proper fix.
Attachment #828389 - Flags: review?(bzbarsky)
Comment on attachment 828389 [details] [diff] [review]
Receive nullable things in initialize() and use ise() instead of is() in the tests.

Making already-optional arguments also nullable is about null handling, not undefined handling, right?

r=me if so
Attachment #828389 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/0526eb0b1f08
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: