935828 - [hamachi][fugu]Volume warning in FM app do not disappear after click home key

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Xinhe Yan]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/535.19 (KHTML, like Gecko) Ubuntu/11.04 Chromium/18.0.1025.151 Chrome/18.0.1025.151 Safari/535.19

Steps to reproduce:

1 Plug in earphone->Access FM app
2 Add volume and pop up a "Volume warning"
3 Click Home key


Actual results:

"Volume warning" still in the top of window, but FM app turn to back
I can see idle behind "Volume warning".

Comment 1

[Steven Yang [:styang]]

Pin, wanna take it?

Comment 2

[Pin Zhang [:pzhang] (inactive)]

May I know the schedule?

Comment 3

[Pin Zhang [:pzhang] (inactive)]

It's not fm app's bug, it should be bug for system app.

Comment 4

[Steven Yang [:styang]]

Alive, wanna take a look on it?

Comment 5

[[e-mail]]

Attachment: pull request redirect to github

it can be reproduced in gaia-master as well.

One line patch.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8342835 [details] [review]
pull request redirect to github

It makes no sense to put in sound manager.

Comment 7

[[e-mail]]

Comment on attachment 8342835 [details] [review]
pull request redirect to github

The volume warning dialog is located within sound manager, so I think it's proper to hide dialog here. 
(Sound manager looks untestable though, we should refactor it)

Add holdhome case as well and ask review again.

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8342835 [details] [review]
pull request redirect to github

Still a bad pattern if some other module in system is using custom dialog but this is OOS of this bug.

Comment 9

[[e-mail]]

merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/22f7ea4e7fa50d16834b838f3c356ca86810db24

thanks!

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

[v1.2f 9aa0abe] Merge pull request #14385 from gasolin/issue-935828