935840 - Add b2g script moz2d-record.sh

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Benoit Girard (:BenWa)]

Attachment: patch

Bug 935701 added the ability to record moz2d drawing commands. This script makes it easy to record and capture profiles.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Comment on attachment 828447 [details] [diff] [review]
patch

Review of attachment 828447 [details] [diff] [review]:
-----------------------------------------------------------------

::: moz2d-record.sh
@@ +5,5 @@
> +SCRIPT_NAME=$(basename $0)
> +
> +ADB=adb
> +PROFILE_DIR=/data/local/tmp
> +PROFILE_PATTERN=${PROFILE_DIR}/'profile_?_*.txt';

These two assignments seem to be unused?

@@ +18,5 @@
> +HELP_start="Restart b2g with moz2d draw call recording."
> +cmd_start() {
> +  echo "Stopping b2g"
> +  $ADB shell stop b2g
> +  $ADB shell rm /data/local/tmp/moz2drec_*

Nit: The * should be quoted. It probably won't make a difference in practice given how bash handles globs, but “explicit is better than implicit”.

@@ +30,5 @@
> +cmd_stop() {
> +  echo "Stopping b2g"
> +  $ADB shell stop b2g
> +  echo "Pulling recording(s)"
> +  $ADB shell ls /data/local/tmp/moz2drec_* | tr '\r' ' ' | xargs -n1 $ADB pull

As above for the *.  Also, an even smaller nit: could that be `tr -d '\r'`?

@@ +38,5 @@
> +}
> +
> +HELP_clean="Clean the moz2drec files."
> +cmd_clean() {
> +  rm moz2drec_*.aer

This is `moz2drec_*.aer`, but the other globs are just `moz2drec_*`.  Is that a problem?

Comment 2

[Benoit Girard (:BenWa)]

Attachment: patch + nits

Comment 3

[Benoit Girard (:BenWa)]

https://github.com/mozilla-b2g/B2G/pull/295