935897 - Editor stylesheet does not match the document stylesheet

Status: VERIFIED FIXED

(developer.mozilla.org Graveyard :: Editing, defect, P1)

Description

[Jeremie Patonnier :Jeremie]

When you edit a document, the styles applied within the editor are different than the one use to display the document. This especially obvious on titles and tables.

Comment 1

[Jean-Yves Perrier [:teoli]]

This happens also for syntax boxes.

Ali: I propose to block on this. It is not a big amount of work, and this nullify the usage of a wysiwig editors. It will raise the bar for new editors that will have to understand why it is different.

Comment 2

[David Walsh :davidwalsh]

Not that I don't believe you but can I get a screenshot or can you let me know what element(s).  A link would be hot too.

Comment 3

[Jean-Yves Perrier [:teoli]]

Attachment: Screen Shot 2013-11-07 at 17.00.22.png

H2 h3 are old style

so also are the in-content spec boxes.

Comment 4

[David Walsh :davidwalsh]

JYP:  Can you confirm that the cache clearing fixed all of the issues listed in this ticket?  They should all be solved.  Cache should no longer be an issue moving forward because the URLs are all cache-busted now.

Comment 5

[Jean-Yves Perrier [:teoli]]

I confirm that the cache clearing fixed all the issues in the editor stylesheet described this.

I only see some wrong <h2> styling in the translation stylesheet (edit window). David, is this the same (and there I must investigate by clearing the cache again), or is it a different stylesheet and therefore a new bug.

If a different stylesheet, one can close this bug.

Comment 6

[Jean-Yves Perrier [:teoli]]

I'm reopening this one. I again get a lot of the old styles in the editor pages. As it was fixed last week by a cache clearing, this means that something is corrupting my cache again!

Is it possible that if I access the site not logged in or not in beta mode that could "corrupt" the locale cache?

Comment 7

[David Walsh :davidwalsh]

I'm wondering if it's a between-two-designs caching issue.  I'm going to leave this open for now.  So confused because this doesn't happen locally.

Comment 8

[Jean-Yves Perrier [:teoli]]

I will double check in a couple of days if is still happens. (Auto-feedbacking me so that I don't forget)

Comment 9

[Luke Crouch [:groovecoder]]

:teoli - how does this look now?

Comment 10

[Jean-Yves Perrier [:teoli]]

No change. When I clear the cache it is ok for some time, then goes back to the old style.

Comment 12

[Māris Fogels [:mars] (please needinfo)]

:teoli, are you still seeing the strange caching behaviour?

Comment 13

[Jean-Yves Perrier [:teoli]]

Yes, I see no difference. Māris, do you see the correct styles in production (in an edit window)?

Comment 14

[David Walsh :davidwalsh]

I found a class on the body that we may not need.  PR here and CSS collisions should finally stop:

https://github.com/mozilla/kuma/pull/2016

Comment 15

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/c96696f3db885e4ecd3c25590a5e508bb8ccb886
fix bug 935897 - Remove unneeded class from ckeditor content body

https://github.com/mozilla/kuma/commit/48b7eebf2297600a28d17e31c6f1777f2dea1ca0
Merge pull request #2016 from darkwing/stylesheet-935897

fix bug 935897 - Remove unneeded class from ckeditor content body

Comment 16

[Jean-Yves Perrier [:teoli]]

It looks ok today \o/

I will keep an eye opened, but I'm fairly confident it is fixed.