Closed
Bug 935923
Opened 11 years ago
Closed 11 years ago
Rename AlphaMode helper function and stop using it
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: mstange, Assigned: mstange)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
|
6.41 KB,
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
The AlphaMode function in D2DHelpers.h conflicts with the AlphaMode enum I want to add in Filters.h. And in most places we can just use D2DPixelFormat instead.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #828579 -
Flags: review?(bas)
|
|
Assignee | |
Comment 3•11 years ago
|
||
missed one
Attachment #828579 -
Attachment is obsolete: true
Attachment #828579 -
Flags: review?(bas)
Attachment #828589 -
Flags: review?(bas)
|
||
Comment 4•11 years ago
|
||
Comment on attachment 828589 [details] [diff] [review] rename-alphamode Review of attachment 828589 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me! Please push to both Moz2D and m-c.
Attachment #828589 -
Flags: review?(bas) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Pushed to moz2d as http://hg.mozilla.org/users/bschouten_mozilla.com/moz2d/rev/dedbf68bcba7
|
|
Assignee | |
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee8d7b270b8f
|
||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ee8d7b270b8f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•