935925 - Modify/replace slugify to fix several issues with title slugs

Status: RESOLVED DUPLICATE of bug 903143

(Webmaker Graveyard :: Thimble, defect)

Description

[Laura Hilliger [:epilepticrabbit]]

If you have a space at the end of the "Name", the published Thimble make has a URL that ends with a dash (-). Like this:

https://janepark.makes.org/thimble/digital-selfpreservation-toolkit-

If you don't include that final dash, you get a 404: https://janepark.makes.org/thimble/digital-selfpreservation-toolkit

The space at the end is likely accidental (it was for me, i removed it and republished to save my URL), is there a way we can say "yo, if this is the last character, remove the space"?

Comment 1

[Jon Buckley [:jbuck]]

Yeah, I think this is something I can fix up with some fixes to our slugifier.

Comment 2

[Pomax]

We also used to have a ticket for slugify mangling unicode in titles, so I'm morphing this issue into one for fixing up the slugifier in general. This it needs to do:

- trim before slugifying
- slugify unicode instead of stripping it
- profit

Comment 3

[Jon Buckley [:jbuck]]

Found it! We'll let :elnushaj take this