936008 - crash in java.lang.NullPointerException: at org.mozilla.gecko.gfx.LayerView.setZoomConstraints(LayerView.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Aaron Train [:aaronmt]]

This bug was filed from the Socorro interface and is 
report bp-6ec12421-8976-4568-9de5-8b22d2131106.
=============================================================

ava.lang.NullPointerException
	at org.mozilla.gecko.gfx.LayerView.setZoomConstraints(LayerView.java:349)
	at org.mozilla.gecko.gfx.LayerView.onTabChanged(LayerView.java:668)
	at org.mozilla.gecko.Tabs$5.run(Tabs.java:572)

Comment 1

[Kartikaya Gupta (email:[e-mail])]

This probably happens because LayerView can be destroyed and re-created (particularly if you have "Don't keep activities" enabled) and the code in bug 932690 assumes that will never happen. It needs to unregister itself on destroy.

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch

Seems like a good patch regardless, but I don't see this crash with don't keep activities set...

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 829461 [details] [diff] [review]
Patch

Review of attachment 829461 [details] [diff] [review]:
-----------------------------------------------------------------

Well hopefully the crashstats will let us know one way or the other.

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/81e01946ed20

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/81e01946ed20

Comment 6

[Kevin Brosnan [Ex-Mozilla]]

Still crashing on Android 4.0+ devices.

samsung     SM-P600         18 (REL)
PANTECH     PantechP9090    16 (REL)
LGE         Nexus 4         19 (REL)
samsung     GT-I9100        19 (UNOFFICIAL)
unknown     MID9742         15 (REL)
samsung     GT-I9300        16 (REL)
samsung     GT-N7000        17 (REL)
asus        Nexus 7         19 (REL)
samsung     GT-I9070P       16 (REL)
OUYA        OUYA Console    16 (REL)
samsung     GT-I9000        19 (REL)

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

#9 on Fx29 (nightly)
#1 on Fx28 (aurora)

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Looking at a recent stack from one of the crash reports, it looks like this must be happening between when the LayerView is constructed and when intializeView is called on it, because that's the only time mLayerClient is null.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch attempt 2

Possible fix. I haven't compiled or tested it at all yet.

Comment 10

[Kartikaya Gupta (email:[e-mail])]

https://tbpl.mozilla.org/?tree=Try&rev=c5907c1b7b0d

Comment 11

[Kartikaya Gupta (email:[e-mail])]

The above try push had failures, probably because it was based on a bad inbound build. I rebased on m-c and repushed and it's looking much better:

https://tbpl.mozilla.org/?tree=Try&rev=365c5459c65a

Comment 12

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/fx-team/rev/5327f5b72d98

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5327f5b72d98

Comment 14

[Lukas Blakk [:lsblakk] use ?needinfo]

please provide an uplift nomination

Comment 15

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8360513 [details] [diff] [review]
Patch attempt 2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 932690
User impact if declined: crashes (this is apparently an Android topcrasher)
Testing completed (on m-c, etc.): not really since it's hard to reproduce locally. we should keep an eye on the crash stats to verify the fix before uplifting.
Risk to taking this patch (and alternatives if risky): pretty low-risk; the code is well understood. affects Fennec only
String or IDL/UUID changes made by this patch: none

Comment 16

[Kartikaya Gupta (email:[e-mail])]

The patch seems to have worked; crash-stats reports that the latest nightly to crash with this problem was on the 14th of jan.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5bfa3b09e612

Comment 18

[Chris Peterson [:cpeterson]]

Removing steps-wanted keyword because this bug has been resolved.

Comment 19

[Chris Peterson [:cpeterson]]

Removing steps-wanted keyword because this bug has been resolved.