936068 - packing addons with -o using current sdk (1.15?) breaks in Firefox 26 (beta)

Status: RESOLVED WONTFIX

(Add-on SDK Graveyard :: General, defect)

Description

[Tomislav Jovanovic :zombie]

it seems the new ES6 generator syntax: function* is used in a couple of files. here is the commit that introduced the offending code:

https://github.com/mozilla/addon-sdk/commit/1910af733de7bd7ecec815aa2cf86947c21e1925

but since this only happens with the -o switch it might be the case of "an unsupported combination of Fx and SDK libraries versions"..

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I think this is just going to be a mismatched combination until Firefox catches up. The master branch of the SDK tracks and only really supports the current Nightly builds of Firefox.

Comment 2

[Tomislav Jovanovic :zombie]

Attachment: link to pr 1290

i know this was WONTFIXed, but:
1) the fix is very simple: just use old style generator functions in two places (since they don't use StopIteration nor 'return', semantics are the same)
2) the master branch has moved to 1.15b, probably to be released soon (alongside Firefox 26?), which would make two products released at the same time not working well together.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/1aab173987fdd4adefebe3cbf70aee34f53a6c57
bug 936068 - fix packing with -o to work in Fx26

very simple change to use old mozilla-style generator functions

https://github.com/mozilla/addon-sdk/commit/2fd05f3a20be2ca4be9019e032f5936e8e9cde14
Merge pull request #1290 from zombie/936068-es6-generators

bug 936068: Use old-style generators to work in current Firefox release. r=Mossop

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/a0671f200de80422b1c83492b046431276183a5d
Revert "bug 936068 - fix packing with -o to work in Fx26"

This reverts commit 1aab173987fdd4adefebe3cbf70aee34f53a6c57.

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Causing some test failures that use iterators, reverting back out for now

Comment 6

[Tomislav Jovanovic :zombie]

this was discussed yesterday: if it was any more complicated than my proposed fix, this would be a WONTFIX.

it turned out my "fix" was bad, it would be more complicated, so i'm closing the bug.